Skip to content

[GLUTEN-9456][VL] Override clone in GlutenDirectBufferedInput #11933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rui-mo wants to merge 1 commit into
base: main
Choose a base branch
from
+28 −2
Open

[GLUTEN-9456][VL] Override clone in GlutenDirectBufferedInput #11933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions cpp/velox/memory/GlutenDirectBufferedInput.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,32 @@ class GlutenDirectBufferedInput : public facebook::velox::dwio::common::DirectBu
}
coalescedLoads_.clear();
}

std::unique_ptr<facebook::velox::dwio::common::BufferedInput> clone() const override {
return std::unique_ptr<facebook::velox::dwio::common::BufferedInput>(new GlutenDirectBufferedInput(
input_, fileNum_, tracker_, groupId_, ioStatistics_, ioStats_, executor_, options_));
}

private:
// Constructor used by clone().
GlutenDirectBufferedInput(
std::shared_ptr<facebook::velox::dwio::common::ReadFileInputStream> input,
facebook::velox::StringIdLease fileNum,
std::shared_ptr<facebook::velox::cache::ScanTracker> tracker,
facebook::velox::StringIdLease groupId,
std::shared_ptr<facebook::velox::io::IoStatistics> ioStatistics,
std::shared_ptr<facebook::velox::IoStats> ioStats,
folly::Executor* executor,
const facebook::velox::io::ReaderOptions& readerOptions)
: DirectBufferedInput(
std::move(input),
std::move(fileNum),
std::move(tracker),
std::move(groupId),
std::move(ioStatistics),
std::move(ioStats),
executor,
readerOptions) {}
};

} // namespace gluten
4 changes: 2 additions & 2 deletions ep/build-velox/src/get-velox.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
set -exu

CURRENT_DIR=$(cd "$(dirname "$BASH_SOURCE")"; pwd)
VELOX_REPO=https://github.com/IBM/velox.git
VELOX_BRANCH=dft-2026_04_13
VELOX_REPO=https://github.com/rui-mo/velox-dev.git
VELOX_BRANCH=dft-2026_04_13_fix
VELOX_ENHANCED_BRANCH=ibm-2026_04_13
VELOX_HOME=""
RUN_SETUP_SCRIPT=ON
Expand Down
Loading