Skip to content

chore(java): Remove redundant code #2375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(java): Remove redundant code #2375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4430cd1
chore(java): Remove redundant code
LiangliangSui Jul 4, 2025
d2389b5
Merge branch 'main' into remove_code
LiangliangSui Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion java/fory-core/src/main/java/org/apache/fory/resolver/ClassResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,7 +749,6 @@ public void registerSerializer(Class<?> type, Serializer<?> serializer) {
}
addSerializer(type, serializer);
ClassInfo classInfo = classInfoMap.get(type);
classInfoMap.put(type, classInfo);
// in order to support customized serializer for abstract or interface.
if (!type.isPrimitive() && (ReflectionUtils.isAbstract(type) || type.isInterface())) {
extRegistry.absClassInfo.put(type, classInfo);
Expand Down
28 changes: 4 additions & 24 deletions java/fory-core/src/main/java/org/apache/fory/serializer/SerializationBinding.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,42 +227,22 @@ public void writeNonRef(MemoryBuffer buffer, Object obj, ClassInfoHolder classIn

@Override
public void writeNullable(MemoryBuffer buffer, Object obj) {
if (obj == null) {
buffer.writeByte(Fory.NULL_FLAG);
} else {
buffer.writeByte(NOT_NULL_VALUE_FLAG);
writeNonRef(buffer, obj);
}
fory.writeNullable(buffer, obj);
Copy link
Collaborator

@chaokunyang chaokunyang Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually inline have better performance. JVM JIT nto always inline those calls

}

@Override
public void writeNullable(MemoryBuffer buffer, Object obj, Serializer serializer) {
if (obj == null) {
buffer.writeByte(Fory.NULL_FLAG);
} else {
buffer.writeByte(NOT_NULL_VALUE_FLAG);
serializer.write(buffer, obj);
}
fory.writeNullable(buffer, obj, serializer);
}

@Override
public void writeNullable(MemoryBuffer buffer, Object obj, ClassInfoHolder classInfoHolder) {
if (obj == null) {
buffer.writeByte(Fory.NULL_FLAG);
} else {
buffer.writeByte(NOT_NULL_VALUE_FLAG);
fory.writeNonRef(buffer, obj, classResolver.getClassInfo(obj.getClass(), classInfoHolder));
}
fory.writeNullable(buffer, obj, classInfoHolder);
}

@Override
public void writeNullable(MemoryBuffer buffer, Object obj, ClassInfo classInfo) {
if (obj == null) {
buffer.writeByte(Fory.NULL_FLAG);
} else {
buffer.writeByte(NOT_NULL_VALUE_FLAG);
fory.writeNonRef(buffer, obj, classInfo);
}
fory.writeNullable(buffer, obj, classInfo);
}

@Override
Expand Down
Loading