[Flink] Support Partial Updates to the Flink Sink #2042
+456
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
| String col = specifiedColumns.get(i); | ||
| int idx = allFieldNames.indexOf(col); | ||
| checkArgument( | ||
| idx >= 0, "Column '%s' not found in table schema: %s", col, allFieldNames); |
There was a problem hiding this comment.
nit: Slightly more context can be provided in the message e.g. "Partial update column '%s' not found in table schema: %s'
There was a problem hiding this comment.
Pull request overview
This PR adds support for partial updates in the Flink Sink, allowing users to update only specific columns in upsert operations while preserving other column values. The implementation ensures that primary key columns are always included in partial update specifications.
Key Changes:
- Added
setPartialUpdateColumnsAPI toFlussSinkBuilderfor specifying which columns to update - Implemented validation logic to ensure partial updates include all primary key columns
- Added comprehensive integration tests covering multiple partial update scenarios
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| FlussSinkBuilder.java | Adds partial update column configuration API and validation logic to compute target column indexes |
| FlussSinkBuilderTest.java | Adds unit tests for the new computeTargetColumnIndexes method covering valid and invalid scenarios |
| FlussSinkITCase.java | Adds three integration tests demonstrating partial updates with different writer configurations and data types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fluss-flink/fluss-flink-common/src/test/java/org/apache/fluss/flink/sink/FlussSinkITCase.java
Show resolved
Hide resolved
fluss-flink/fluss-flink-common/src/test/java/org/apache/fluss/flink/sink/FlussSinkITCase.java
Show resolved
Hide resolved
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/sink/FlussSinkBuilder.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.