Support Add Column in Fluss. #2010
Open
+5,727
−968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuchong
reviewed
Nov 24, 2025
fluss-server/src/main/java/org/apache/fluss/server/coordinator/MetadataManager.java
Outdated
Show resolved
Hide resolved
fluss-client/src/main/java/org/apache/fluss/client/admin/FlussAdmin.java
Outdated
Show resolved
Hide resolved
wuchong
reviewed
Nov 24, 2025
|
|
||
| public Column(String columnName, DataType dataType) { | ||
| this(columnName, dataType, null); | ||
| this(columnName, dataType, null, UNKNOWN_COLUMN_ID); |
Member
There was a problem hiding this comment.
We should be able to get the column id for the previous schema (use the column order). Using -1 as default column is error-prone.
Contributor
Author
There was a problem hiding this comment.
Yes, I also want to do it. But as a public api, I cannot remove this constructor Column(String columnName, DataType dataType). If not set -1, I have no idea how to handle it.
| /** Register schema to ZK metadata and return the schema id. */ | ||
| public int registerSchema(TablePath tablePath, Schema schema) throws Exception { | ||
| int currentSchemaId = getCurrentSchemaId(tablePath); | ||
| return registerSchema(tablePath, schema, getCurrentSchemaId(tablePath) + 1); |
Member
There was a problem hiding this comment.
This is creating a new table, we can directly use schema id = 1 here?
Contributor
Author
There was a problem hiding this comment.
sometime schema will be recreated when create table.
loserwang1024
force-pushed
the
poc-schema-change
branch
3 times, most recently
from
279a97d to
2ade0ce
Compare
wuchong
reviewed
Nov 28, 2025
...client/src/main/java/org/apache/fluss/client/table/scanner/batch/KvSnapshotBatchScanner.java
Show resolved
Hide resolved
fluss-common/src/main/java/org/apache/fluss/metadata/TableChange.java
Outdated
Show resolved
Hide resolved
fluss-common/src/main/java/org/apache/fluss/metadata/TableChange.java
Outdated
Show resolved
Hide resolved
fluss-common/src/main/java/org/apache/fluss/metadata/TableInfo.java
Outdated
Show resolved
Hide resolved
fluss-common/src/main/java/org/apache/fluss/record/LogRecordBatch.java
Outdated
Show resolved
Hide resolved
fluss-common/src/main/java/org/apache/fluss/record/LogRecordReadContext.java
Outdated
Show resolved
Hide resolved
fluss-common/src/main/java/org/apache/fluss/row/encode/ValueDecoder.java
Outdated
Show resolved
Hide resolved
fluss-client/src/main/java/org/apache/fluss/client/FlussConnection.java
Outdated
Show resolved
Hide resolved
fluss-common/src/main/java/org/apache/fluss/record/DefaultLogRecordBatch.java
Outdated
Show resolved
Hide resolved
loserwang1024
force-pushed
the
poc-schema-change
branch
4 times, most recently
from
4277102 to
d490cb1
Compare
2. flink write with smaller row
loserwang1024
force-pushed
the
poc-schema-change
branch
from
d490cb1 to
a475aee
Compare
loserwang1024
changed the title
loserwang1024
force-pushed
the
poc-schema-change
branch
from
5829700 to
9742f89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2056
Brief change log
Tests
API and Format
Documentation