[docs] add an explanation for setting the configuration of kv.snapshot.interval to 0s #1971
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiuyunbuyu
changed the title
rionmonster
reviewed
Nov 12, 2025
rionmonster
approved these changes
Nov 12, 2025
Contributor
rionmonster
left a comment
rionmonster
left a comment
There was a problem hiding this comment.
Left a single comment/wording nit; otherwise LGTM!
added 2 commits
November 13, 2025 12:35
Author
@rionmonster Thank you for the review. I agree with your suggestion. Using "disable" does make the behavior more explicit and aligns with the existing comment in apache/fluss#30. I've applied the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While conducting tests following the official Docker deployment guide, I noticed that all kv.snapshot.interval parameters are set to 0S. I found this configuration quite confusing, as the behavior it implies wasn't immediately clear.
I checked the configuration documentation, but it didn't provide a clear explanation for a value of 0S. To understand its meaning, I looked through the code commit history and found the relevant context in PR #30.
Now that I understand its purpose, I would like to propose that we add specific documentation to clarify the special meaning and intended use-case when this parameter is set to 0S. This would prevent confusion for future users.