Repository navigation
[FLINK-30975][filesystems] Update the S3 filesystems to Hadoop 3.4.3 and AWS SDK v2 - #29823
Open
MartijnVisser wants to merge 3 commits into
Open
MartijnVisser wants to merge 3 commits into
MartijnVisser wants to merge 3 commits into
Conversation
Collaborator
The S3 delegation token carried AWS SDK v1's Credentials. It now carries S3SessionCredentials, which has no SDK types, and the STS call sits behind a small client interface. This lets flink-s3-fs-hadoop move to AWS SDK v2 while flink-s3-fs-presto stays on v1. Shutting down the STS client stays best effort, as in FLINK-40855. Co-authored-by: Martijn Visser <2989614+MartijnVisser@users.noreply.github.com> Generated-by: Claude Code (Claude Opus 5.5)
Hadoop 3.3.4 fails on Java 23 and later (HADOOP-19212), and hadoop-aws 3.4 requires AWS SDK v2. flink-s3-fs-hadoop now uses SDK v2 for the recoverable writer and the delegation tokens, while flink-s3-fs-presto stays on SDK v1. The FileSink state format is unchanged, so flink-s3-fs-native can still restore it (FLINK-40943). The writer rejects part checksums, because the state doesn't store them. Common SDK v1 credentials provider names are mapped to their SDK v2 equivalents. Co-authored-by: Martijn Visser <2989614+MartijnVisser@users.noreply.github.com> Generated-by: Claude Code (Claude Opus 5.5)
MartijnVisser
force-pushed
the
FLINK-30975-s3-sdk-v2
branch
from
November 10, 2026 14:05
2ed11e7 to
d1d5aa4
Compare
…r uploads SDK v1 checked the MD5 of each upload against the returned ETag. SDK v2 does not, and the writer rejects S3A's part checksums, so a part corrupted on the way to S3 was committed without an error. Sending Content-MD5 makes S3 reject it. Generated-by: Claude Code (Claude Opus 5.5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
flink-s3-fs-hadoop bundles Hadoop 3.3.4, which fails on Java 23 and later with
getSubject is not supported(HADOOP-19212). hadoop-aws 3.4 requires AWS SDK v2, so this moves the S3 filesystems to Hadoop 3.4.3 and flink-s3-fs-hadoop to SDK v2. It continues #27026 by @ctrlaltdilj.Brief change log
fs.s3a.create.checksum.algorithm,fs.s3a.checksum.generation), because the state doesn't store them.Verifying this change
CredentialProviderListFactory), the version 1 serializer bytes and the Content-MD5 header. An ArchUnit test keeps the token classes SDK-free.-Pjava21-target) and 25. On Java 25 the HA ITCases now pass, while master fails them.HadoopS3FileSystemBehaviorITCasefails one recursive-delete test on SeaweedFS; master fails two.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Claude Opus 5.5)