[hotfix][checkpoint] Refactor common behavior into ChannelStateFilteringHandler#getGateFilterHandler and GateFilterHandler#getVirtualChannelBy to reduce code duplication - #28954
Draft
RocMarshal wants to merge 1 commit into
Conversation
…ingHandler#getGateFilterHandler and GateFilterHandler#getVirtualChannelBy to reduce code duplication in ChannelStateFilteringHandler.java
Collaborator
weiqingy
reviewed
Aug 11, 2026
weiqingy
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the cleanup. I diffed each new helper against both copies of the code it came from and the bodies are identical, so nothing changed in the move. One small note inline.
| } | ||
| } | ||
|
|
||
| private VirtualChannel<T> getVirtualChannelBy(int oldSubtaskIndex, int oldChannelIndex) { |
Contributor
There was a problem hiding this comment.
nit: The comment at line 363 marks everything below it as code that goes away when FLINK-38544 lands. This new helper sits inside that section, but one of its two callers is at line 325, in the overload that stays. Up to now nothing inside the section was called from outside it, so that deletion could be a clean cut. Would moving the helper above line 362 be worth it to keep that true?
RocMarshal
marked this pull request as draft
August 11, 2026 06:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
[hotfix][checkpoint] Refactor common behavior into ChannelStateFilteringHandler#getGateFilterHandler and GateFilterHandler#getVirtualChannelBy to reduce code duplication in ChannelStateFilteringHandler.java
Brief change log
[hotfix][checkpoint] Refactor common behavior into ChannelStateFilteringHandler#getGateFilterHandler and GateFilterHandler#getVirtualChannelBy to reduce code duplication in ChannelStateFilteringHandler.java
Verifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation
Was generative AI tooling used to co-author this PR?
Generated-by: [Tool Name and Version]