[FLINK-40356][table] Add new MapFromEntries function - #28948
Open
VasShabu wants to merge 1 commit into
Open
Conversation
Collaborator
snuyanzin
reviewed
Aug 11, 2026
Comment on lines
+77
to
+93
| final Map<ObjectContainer, Object> entries = new LinkedHashMap<>(); | ||
| for (int pos = 0; pos < input.size(); pos++) { | ||
| final RowData entry = (RowData) entryElementGetter.getElementOrNull(input, pos); | ||
| if (entry == null) { | ||
| return null; | ||
| } | ||
| entries.put( | ||
| wrapKey(keyFieldGetter.getFieldOrNull(entry)), | ||
| valueFieldGetter.getFieldOrNull(entry)); | ||
| } | ||
| return new MapDataForMapFromEntries( | ||
| new GenericArrayData( | ||
| entries.keySet().stream() | ||
| .map(key -> key == null ? null : key.getObject()) | ||
| .toArray()), | ||
| new GenericArrayData(entries.values().toArray())); | ||
| } |
Contributor
There was a problem hiding this comment.
this is a hot path executing during runtime.
We should avoid extra array creation and other things which might be optimized
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The Purpose of this change was to add a new builtin function, MapFromEntries Function to Flink
Brief change log
-Added mapFromEntries functionality
-Wired mapFromEntries function to flink
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
(Please pick either of the following options)
This change is already covered by existing tests, such as the ones located in
to run test you need to run this command:
./mvnw -o -pl flink-table/flink-table-planner -Dtest='JsonFunctionsITCase' -Dsurefire.failIfNoSpecifiedTests=false -Dcheckstyle.skip=true -Dspotless.check.skip=true -Drat.skip=true -e -Denforcer.skip=true test
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 5