Skip to content

[FLINK-39966][table-planner] FlinkRelMdModifiedMonotonicity wrongly reports a non-time-attribute Top-1 Rank as insert-only#28505

Open
lincoln-lil wants to merge 1 commit into
apache:masterfrom
lincoln-lil:FLINK-39966
Open

[FLINK-39966][table-planner] FlinkRelMdModifiedMonotonicity wrongly reports a non-time-attribute Top-1 Rank as insert-only#28505
lincoln-lil wants to merge 1 commit into
apache:masterfrom
lincoln-lil:FLINK-39966

Conversation

@lincoln-lil

Copy link
Copy Markdown
Contributor

What is the purpose of the change

FLINK-34702 removed the dedicated StreamPhysicalDeduplicate metadata handler and re-routed deduplication monotonicity through StreamPhysicalRank, but the new dispatch guard only checked RankUtil.isDeduplication (Top-1 ROW_NUMBER without rank number). It dropped the sortOnTimeAttributeOnly invariant the old node type implicitly carried.

Brief change log

  • Tighten the guard to isDeduplication && sortOnTimeAttributeOnly restoring the original logic.
  • Add proper test cases

Verifying this change

This change added tests and can be verified as follows:

  • Added plan tests to RankTest.scala
  • Added metadata tests to FlinkRelMdModifiedMonotonicityTest.scala

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: (no )
  • The runtime per-record code paths (performance sensitive): ( no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
  • The S3 file system connector: ( no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

…eports a non-time-attribute Top-1 Rank as insert-only

FLINK-34702 removed the dedicated StreamPhysicalDeduplicate metadata handler and
re-routed deduplication monotonicity through StreamPhysicalRank, but the new
dispatch guard only checked RankUtil.isDeduplication (Top-1 ROW_NUMBER without
rank number). It dropped the sortOnTimeAttributeOnly invariant the old node type
implicitly carried.

Tighten the guard to isDeduplication && sortOnTimeAttributeOnly restoring the
original logic.
@flinkbot

flinkbot commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants