[FLINK-39215] [python] Clean up PythonDriver tmp dir on launch failure#28503
Open
qiuyanjun888 wants to merge 1 commit into
Open
[FLINK-39215] [python] Clean up PythonDriver tmp dir on launch failure#28503qiuyanjun888 wants to merge 1 commit into
qiuyanjun888 wants to merge 1 commit into
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR fixes FLINK-39215, where
PythonDrivercould leave behind a generatedpyflink/<uuid>temporary directory ifPythonEnvUtils.launchPy4jPythonClient(...)failed after preparing the Python environment but before returning the Python process.Root cause:
PythonDrivercreated the shutdown hook only afterlaunchPy4jPythonClient(...)returned successfully. WhenpreparePythonEnvironment(...)had already populated the temporary directory andstartPythonProcess(...)then failed, no shutdown hook existed to clean up that directory.Brief change log
tmpDirand Python process reference visible to the failure path inPythonDriver.PythonDriverTestregression test that triggers a Python client launch failure with an invalid-pyclientexecand verifies that no per-runpyflinktmp directory remains.Verifying this change
This change added tests and can be verified as follows:
PythonDriverTest#testCleanupTmpDirWhenPythonClientLaunchFails.pyflink/<uuid>temporary directory was left behind../mvnw -pl flink-python -Dtest=PythonDriverTest#testCleanupTmpDirWhenPythonClientLaunchFails test -DskipITs -Drat.skip=true -Dcheckstyle.skip=truePythonDriverTestclass:./mvnw -pl flink-python -Dtest=PythonDriverTest test -DskipITs -Drat.skip=true -Dcheckstyle.skip=truepython -> python3symlink because this environment does not provide apythoncommand by default:./mvnw -pl flink-python -Dtest=PythonDriverTest,PythonEnvUtilsTest test -DskipITs -Drat.skip=true -Dcheckstyle.skip=truegit diff --check.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Hermes Agent (OpenAI GPT-5.5)