[FLINK-39788][kubernetes] Append .svc suffix to namespaced Kubernetes service hostnames#28493
Open
wilmerdooley wants to merge 1 commit into
Open
[FLINK-39788][kubernetes] Append .svc suffix to namespaced Kubernetes service hostnames#28493wilmerdooley wants to merge 1 commit into
wilmerdooley wants to merge 1 commit into
Conversation
…es namespace starts from digit Signed-off-by: wilmerdooley <wilmerdooley1@gmail.com>
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
When a Flink Session cluster is deployed on Kubernetes, the TaskManager resolves the JobManager RPC endpoint through Pekko using the value returned by
getNamespacedServiceName(and its related helpers). The current implementation produces a hostname of the form<service>.<namespace>, which is not a fully qualified Kubernetes service DNS name and is treated as an opaque host by Pekko. For namespaces whose name begins with a digit (for example1234-ns), DNS resolution fails and the TaskManager logsActor not foundwhile trying to connect to the dispatcher (FLINK-39788).This change appends the
.svcsegment so the namespaced service name becomes the standard Kubernetes service FQDN<service>.<namespace>.svc, which resolves correctly regardless of how the namespace name begins.Brief change log
.svcto the namespaced service name inExternalServiceDecorator.getNamespacedExternalServiceName,InternalServiceDecorator.getNamespacedInternalServiceName, andKubernetesUtils.getNamespacedServiceName, so the result is the FQDN<service>.<namespace>.svc.KubernetesClusterDescriptorTestto match the new fully qualified host.Verifying this change
This change is already covered by existing tests, specifically
KubernetesClusterDescriptorTest.testDeployApplicationClusterWithClusterIP, whose expected web interface URL is updated to assert the new<service>.<namespace>.svchostname.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code