[FLINK-38971][table] Migrate ExpandWindowTableFunctionTransposeRule t…#27643
Open
RVRhub wants to merge 1 commit intoapache:masterfrom
Open
[FLINK-38971][table] Migrate ExpandWindowTableFunctionTransposeRule t…#27643RVRhub wants to merge 1 commit intoapache:masterfrom
RVRhub wants to merge 1 commit intoapache:masterfrom
Conversation
Collaborator
rionmonster
reviewed
Feb 23, 2026
| // 1. transpose Calc and WindowTVF, build the new Calc node (the top node) | ||
| // ------------------------------------------------------------------------- | ||
| ImmutableBitSet windowColumns = fmq.getRelWindowProperties(windowTVF).getWindowColumns(); | ||
| Tuple4<RexProgram, int[], Object, Object> programInfo = |
Contributor
There was a problem hiding this comment.
While this is a non-issue and clearly tied to Java–Scala interop, it does look like we lose some of the stronger typing specifically around the newTimeField and timeFieldAdded properties which gets erased and requires subsequent casts.
Probably not a big deal overall, and likely a non-issue if/when the WindowUtil class makes a similar migration, but figured it was worth calling out.
Contributor
|
@flinkbot run azure |
rionmonster
approved these changes
Feb 23, 2026
Contributor
rionmonster
left a comment
There was a problem hiding this comment.
The migration looks good overall — left one minor comment. I've also kicked off another CI run as a seemingly unrelated issue seemed to bork the existing one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
A bit reasoning for the change
Brief change log
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): ( no)Documentation