Skip to content

Comments

[FLINK-38971][table] Migrate ExpandWindowTableFunctionTransposeRule t…#27643

Open
RVRhub wants to merge 1 commit intoapache:masterfrom
RVRhub:flink38971
Open

[FLINK-38971][table] Migrate ExpandWindowTableFunctionTransposeRule t…#27643
RVRhub wants to merge 1 commit intoapache:masterfrom
RVRhub:flink38971

Conversation

@RVRhub
Copy link
Contributor

@RVRhub RVRhub commented Feb 22, 2026

What is the purpose of the change

A bit reasoning for the change

The reason is that since 1.28.0 ( CALCITE-4787 - Move core to use Immutables instead of ImmutableBeans ) Calcite started to use Immutables (https://immutables.github.io/) and since 1.29.0 removed ImmutableBeans ( CALCITE-4839 - Remove remnants of ImmutableBeans post 1.28 release ). All rule configuration related api which is not Immutables based is marked as deprecated. Since Immutables implies code generation while java compilation it is seems impossible to use for rules in Scala code.

Brief change log

  • The PR migrates ExpandWindowTableFunctionTransposeRule to java
  • It doesn't touch test to be sure that java version continues passing it.

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 22, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

// 1. transpose Calc and WindowTVF, build the new Calc node (the top node)
// -------------------------------------------------------------------------
ImmutableBitSet windowColumns = fmq.getRelWindowProperties(windowTVF).getWindowColumns();
Tuple4<RexProgram, int[], Object, Object> programInfo =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is a non-issue and clearly tied to Java–Scala interop, it does look like we lose some of the stronger typing specifically around the newTimeField and timeFieldAdded properties which gets erased and requires subsequent casts.

Probably not a big deal overall, and likely a non-issue if/when the WindowUtil class makes a similar migration, but figured it was worth calling out.

@rionmonster
Copy link
Contributor

@flinkbot run azure

Copy link
Contributor

@rionmonster rionmonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration looks good overall — left one minor comment. I've also kicked off another CI run as a seemingly unrelated issue seemed to bork the existing one.

@github-actions github-actions bot added the community-reviewed PR has been reviewed by the community. label Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants