Skip to content

[FLINK-38114][runtime] Allow asynchronous offloading of TaskRestore #26821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025

Conversation

Izeren
Copy link
Contributor

@Izeren Izeren commented Jul 22, 2025

What is the purpose of the change

Reduces risks of pekko framesize exceeded errors during task deployment caused by large TaskRestore through asynchronous offloading to the BlobStore.

Brief change log

  • Modifies Execution#deploy() to offload large TaskRestore values using BlobWriter (BlobWriter decides on threshold).
  • Offloading of TaskRestore is done asynchronously to avoid blocks the main thread.
  • As deploy method now returns earlier, additional CompletableFuture<Void> is exported from Execution for testing purposes.
  • Existing impacted tests are adjusted for new behaviour of Execution#deploy.
  • Added new tests to verify new code path.

Verifying this change

  • Existing tests.
  • Additional unit test to verify new code path: ExecutionTest#testExecutionCancelledDuringTaskRestoreOffload

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 22, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@rkhachatryan rkhachatryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort! LGTM

(I've already reviewed an internal version of this change)

@rkhachatryan rkhachatryan merged commit 6b0426c into apache:master Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants