Skip to content

Conversation

Poorvankbhatia
Copy link
Contributor

What is the purpose of the change

This pull request migrates CoGroupJoinITCase integration tests from deprecated SourceFunction/SinkFunction APIs to modern Source V2 and Sink V2 APIs.

Brief change log

  • Replaced 5 inline SourceFunction implementations with env.fromData() calls for static test data
  • Migrated 3 SinkFunction implementations to custom CollectingSink using Sink V2 API
  • Maintained identical test behavior and assertions while modernizing the underlying APIs

Verifying this change

This change is already covered by existing tests, such as:

  • All test methods in CoGroupJoinITCase (testCoGroup, testJoin, testSelfJoin, testCoGroupOperatorWithCheckpoint)
  • Tests verify identical windowed join/coGroup behavior with updated APIs
  • Same expected results and assertions maintained across the migration.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@Poorvankbhatia
Copy link
Contributor Author

Hey @afedulov PTAL. Thanks :)

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 22, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@fapaul fapaul self-requested a review August 5, 2025 09:17
Copy link
Contributor

@fapaul fapaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for also fixing up the general test structure 👍

@fapaul fapaul merged commit 59278c9 into apache:master Aug 7, 2025
@Poorvankbhatia Poorvankbhatia deleted the FLINK-32695-CoGroupJoinITCase-Source/SinkV2-Migration branch August 18, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants