Skip to content

Conversation

Laffery
Copy link
Contributor

@Laffery Laffery commented Jul 16, 2025

What is the purpose of the change

Angular framework and NG-ZORRO both have released their stable v19 versions. It is a good time to bump them to the latest.

Brief change log

  • update frontend framework angular and ng-zorro-antd to v19
  • migrate angular builder to application (which is default in v19)
  • remove redundant standalone:true (which is default in v19)
  • move utility function typeDefinition to public-api

Verifying this change

Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

})
export class AutoResizeDirective implements OnDestroy, OnInit {
private destroy$ = new Subject<void>();
hiddenMinimap = false;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 16, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Laffery Laffery marked this pull request as ready for review July 16, 2025 05:36
@Laffery Laffery force-pushed the chore/angular-v19 branch from 244aca2 to 86b7a90 Compare July 16, 2025 05:58
Copy link
Contributor

@davidradl davidradl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial contribution of a change should be made to master and then backported appropriately.

Can I check why we have not gone for Angular 20 which now has a stable release?

@github-actions github-actions bot added the community-reviewed PR has been reviewed by the community. label Jul 16, 2025
@Laffery
Copy link
Contributor Author

Laffery commented Jul 16, 2025

The initial contribution of a change should be made to master and then backported appropriately.

Can I check why we have not gone for Angular 20 which now has a stable release?

Thanks for your reminder, I will create a new one to the master branch.

Of course I can update to angular v20 directly, I will do the change :)

@github-actions github-actions bot added community-reviewed PR has been reviewed by the community. and removed community-reviewed PR has been reviewed by the community. labels Jul 17, 2025
@github-actions github-actions bot added community-reviewed PR has been reviewed by the community. and removed community-reviewed PR has been reviewed by the community. labels Jul 28, 2025
@github-actions github-actions bot added community-reviewed PR has been reviewed by the community. and removed community-reviewed PR has been reviewed by the community. labels Aug 4, 2025
@Laffery Laffery closed this Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-reviewed PR has been reviewed by the community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants