-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-38044][runtime-web] update angular to v19 #26801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
}) | ||
export class AutoResizeDirective implements OnDestroy, OnInit { | ||
private destroy$ = new Subject<void>(); | ||
hiddenMinimap = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useless
244aca2
to
86b7a90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initial contribution of a change should be made to master and then backported appropriately.
Can I check why we have not gone for Angular 20 which now has a stable release?
Thanks for your reminder, I will create a new one to the master branch. Of course I can update to angular v20 directly, I will do the change :) |
What is the purpose of the change
Angular framework and NG-ZORRO both have released their stable v19 versions. It is a good time to bump them to the latest.
Brief change log
angular
andng-zorro-antd
to v19application
(which is default in v19)standalone:true
(which is default in v19)typeDefinition
to public-apiVerifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation