Skip to content

[FLINK-37822][tests] Fix flaky test: OpenTelemetryMetricReporterITCase.testReport #26650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025
Merged

[FLINK-37822][tests] Fix flaky test: OpenTelemetryMetricReporterITCase.testReport #26650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...metrics-otel/src/main/java/org/apache/flink/metrics/otel/OpenTelemetryMetricReporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ public void open(MetricConfig metricConfig) {
@Override
public void close() {
exporter.flush();
lastResult.join(1, TimeUnit.MINUTES);
waitForLastReportToComplete();
exporter.close();
}

Expand Down Expand Up @@ -268,4 +268,11 @@ public void report() {
exporter.getClass().getName());
}
}

@VisibleForTesting
void waitForLastReportToComplete() {
if (lastResult != null) {
lastResult.join(1, TimeUnit.MINUTES);
}
}
}
4 changes: 4 additions & 0 deletions ...s-otel/src/test/java/org/apache/flink/metrics/otel/OpenTelemetryMetricReporterITCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,10 @@ public void testReport() throws Exception {
reporter.notifyOfAddedMetric(gauge, "foo.gauge", group);

reporter.report();
// Reporting is async, hence reports order is not deterministic.
// As test utils rely on verification of "last" report, we enforce report order
// for testing purposes.
reporter.waitForLastReportToComplete();

MeterView meter = new MeterView(counter);
reporter.notifyOfAddedMetric(meter, "foo.meter", group);
Expand Down