Skip to content

[hotfix] Removed Extraneous Semicolon #26608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[hotfix] Removed Extraneous Semicolon #26608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...nk-file-sink-test/src/main/java/org/apache/flink/connector/file/sink/FileSinkProgram.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
* a complete sequence from 0 (inclusive) to 60000 (exclusive).
*/
public enum FileSinkProgram {
;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the Jira does not seem to exist. I suggest this is a trivial hot fix, if a committer wants to merge they can, but it is very low priority

Copy link
Contributor Author

@rionmonster rionmonster May 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FLINK-28847 was the JIRA ticket that I found related to the same area. I do agree that this is fairly trivial and not at all a priority, just figured it was a quick, easy fix.

Copy link
Contributor

@davidradl davidradl Jun 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rionmonster could you change the title to start with [hotfix]. I will approve and suggest it be merged in the
CHI workgroup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's so strange that the JIRA isn't showing up for you. I had added a comment on it to be assigned, but either way, it's pretty trivial. I've gone ahead and updated the title accordingly.

If you'd prefer, I could also create a new PR with the non-JIRA'd commit message for consistency.


public static void main(final String[] args) throws Exception {
final ParameterTool params = ParameterTool.fromArgs(args);
Expand Down