Skip to content

[hotfix] Remove unnecessary method override for method invoke #26462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

beliefer
Copy link
Contributor

@beliefer beliefer commented Apr 15, 2025

What is the purpose of the change

This PR aims to remove unnecessary method override for method invoke.
The interface TaskInvokable provides a method invoke show below.
void invoke() throws Exception;
As an implementation, AbstractInvokable overrides it. We could remove it.

Brief change log

Remove unnecessary method override for method invoke.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@beliefer beliefer changed the title [hotfix] Remove unnecessary method overloading for method invoke [hotfix] Remove unnecessary method override for method invoke Apr 15, 2025
Copy link
Contributor

@davidradl davidradl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trivial change

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 15, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@beliefer
Copy link
Contributor Author

ping @StephanEwen cc @1996fanrui @GOODBOY008

Copy link
Contributor

@lsyldliu lsyldliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsyldliu lsyldliu merged commit a48d090 into apache:master May 19, 2025
@beliefer
Copy link
Contributor Author

@lsyldliu @davidradl Thank you !

yanand0909 pushed a commit to yanand0909/flink that referenced this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants