Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-37024][task] Make cancel watchdog cover tasks stuck in DEPLOYING state #25915

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

X-czh
Copy link
Contributor

@X-czh X-czh commented Jan 7, 2025

What is the purpose of the change

Fix the issue that task can be stuck in deploying state forever when canceling job/failover.

Brief change log

Make cancel watchdog cover tasks stuck in DEPLOYING state.

Verifying this change

Added UT, mocking an invokable stuck in the constructor forever.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 7, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@huwh huwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor comment. PTAL

@X-czh X-czh requested a review from huwh January 9, 2025 05:49
@huwh huwh merged commit 37c70c4 into apache:master Jan 10, 2025
@X-czh X-czh deleted the FLINK-37024 branch January 10, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants