Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-37019][tests] Bump junit5 to 5.11.4 #25906

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FLINK-37019][tests] Bump junit5 to 5.11.4 #25906

wants to merge 1 commit into from
+24 −5

Conversation

snuyanzin
Copy link
Contributor

What is the purpose of the change

Among others there is now support of parameterized tests with @FieldSource
https://junit.org/junit5/docs/current/user-guide/#writing-tests-parameterized-tests-sources-FieldSource

Brief change log

pom files

Verifying this change

This change is already covered by existing tests, such as (please describe tests).

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes )
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: ( no)
  • The runtime per-record code paths (performance sensitive): ( no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no)
  • The S3 file system connector: ( no)

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable )

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 6, 2025 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

liuyongvs
liuyongvs reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@liuyongvs liuyongvs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 @snuyanzin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidradl davidradl davidradl approved these changes

@liuyongvs liuyongvs liuyongvs approved these changes

Assignees
No one assigned
Labels
component=TestInfrastructure component=Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snuyanzin @flinkbot @liuyongvs @davidradl