Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36181] Use Java 17 by default #25898

Merged
merged 12 commits into from
Jan 15, 2025

Conversation

MartijnVisser
Copy link
Contributor

@MartijnVisser MartijnVisser commented Jan 5, 2025

What is the purpose of the change

This PR changes Flink CI to run on Java 17 by default, effectively dropping support for Java 8. Since Java 11 is officially not deprecated, there's a separate Java profile to run JDK11 tests during the nightly cron builds.

Brief change log

  • Changes CI to run on Java 17 by default, and removes Java 8 in the CI runs
  • Bumps Scala to 2.12.20, since we're already in Flink 2.0 land and we can safely break this for the upgrade to Java 17.
  • Updates README

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): don't know
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? docs

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 5, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@snuyanzin
Copy link
Contributor

snuyanzin commented Jan 5, 2025

@MartijnVisser I think you need to rebase to the latest master
the failure seems to be related to the bug in master fixed within FLINK-37006

This is a breaking change for Flink 2.0, and allows us to next remove the specific Scala versions for both Java 17 and 21
Since we've bumped Scala all together, we no longer need to bump it for these profiles
@MartijnVisser MartijnVisser force-pushed the FLINK-36181-java17-default branch from a0684fd to a672ec6 Compare January 5, 2025 15:18
@MartijnVisser MartijnVisser marked this pull request as ready for review January 5, 2025 20:09
@MartijnVisser MartijnVisser changed the title [WIP][FLINK-36181] Use Java 17 by default [FLINK-36181] Use Java 17 by default Jan 6, 2025
pom.xml Show resolved Hide resolved
@MartijnVisser MartijnVisser force-pushed the FLINK-36181-java17-default branch from 5e99536 to a35449a Compare January 8, 2025 10:36
README.md Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@snuyanzin snuyanzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing comments

LGTM in general

One thing would be nice to have: a test run of nightly jobs before merging (not sure whether it is possible now)

@snuyanzin
Copy link
Contributor

Last minute comment
I noticed we have also scala version mentioned at

<scala.version>2.12.16</scala.version>

how about sync it with the one in main pom?

@MartijnVisser
Copy link
Contributor Author

@flinkbot run azure

@MartijnVisser MartijnVisser merged commit 997b483 into apache:master Jan 15, 2025
@MartijnVisser MartijnVisser deleted the FLINK-36181-java17-default branch January 15, 2025 11:25
jiexray added a commit to jiexray/flink that referenced this pull request Jan 16, 2025
fredia added a commit to fredia/flink that referenced this pull request Jan 17, 2025
JunRuiLee added a commit to JunRuiLee/flink that referenced this pull request Jan 21, 2025
JunRuiLee added a commit to JunRuiLee/flink that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants