-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-36181] Use Java 17 by default #25898
[FLINK-36181] Use Java 17 by default #25898
Conversation
@MartijnVisser I think you need to rebase to the latest master |
This is a breaking change for Flink 2.0, and allows us to next remove the specific Scala versions for both Java 17 and 21
Since we've bumped Scala all together, we no longer need to bump it for these profiles
a0684fd
to
a672ec6
Compare
5e99536
to
a35449a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing comments
LGTM in general
One thing would be nice to have: a test run of nightly jobs before merging (not sure whether it is possible now)
Last minute comment flink/flink-rpc/flink-rpc-akka/pom.xml Line 42 in 105720f
how about sync it with the one in main pom? |
@flinkbot run azure |
This reverts commit 997b483.
This reverts commit 997b483.
This reverts commit 997b483.
This reverts commit 997b483.
What is the purpose of the change
This PR changes Flink CI to run on Java 17 by default, effectively dropping support for Java 8. Since Java 11 is officially not deprecated, there's a separate Java profile to run JDK11 tests during the nightly cron builds.
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation