New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-32889] Fix calcuation of weighted areaUnderROC and areaUnderPRC in BinaryClassificationEvaluator #252

Merged

zhipeng93 merged 5 commits into apache:master from Fanoid:FLINK-32889

Aug 24, 2023

+86 −239

Contributor

Fanoid commented Aug 18, 2023

What is the purpose of the change

Right now, BinaryClassificationEvaluator gives wrong areaUnderROC (auROC) and areaUnderPRC (auPRC) values when a weight column provided. This PR provides fix for their calculation.

Brief change log

Correct the expected values in the weighted case in BinaryClassificationEvaluatorTest.
Correct the calculation of weighted auROC and auPRC.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no) no
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no) no

Documentation

Does this pull request introduce a new feature? (yes / no) no
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) not applicable

Fanoid added 2 commits

August 17, 2023 19:30


          Correct the weighted case in BinaryClassificationEvaluatorTest.

1cba34f


          Make weighted auROc and auPRC correct.

9a7b851

Contributor Author

Fanoid commented Aug 18, 2023

@weibozhao Could you help review this PR?

weibozhao reviewed

View reviewed changes

.../java/org/apache/flink/ml/evaluation/binaryclassification/BinaryClassificationEvaluator.java Outdated Show resolved Hide resolved

weibozhao reviewed

View reviewed changes

.../java/org/apache/flink/ml/evaluation/binaryclassification/BinaryClassificationEvaluator.java Show resolved Hide resolved

weibozhao reviewed

View reviewed changes

.../java/org/apache/flink/ml/evaluation/binaryclassification/BinaryClassificationEvaluator.java Outdated Show resolved Hide resolved

weibozhao reviewed

View reviewed changes

.../java/org/apache/flink/ml/evaluation/binaryclassification/BinaryClassificationEvaluator.java Show resolved Hide resolved

weibozhao reviewed

View reviewed changes

...k-ml-lib/src/test/java/org/apache/flink/ml/evaluation/BinaryClassificationEvaluatorTest.java Show resolved Hide resolved

weibozhao reviewed

View reviewed changes

.../java/org/apache/flink/ml/evaluation/binaryclassification/BinaryClassificationEvaluator.java Outdated Show resolved Hide resolved

Contributor

weibozhao commented Aug 21, 2023 •

edited

Loading

@weibozhao Could you help review this PR?

Thanks for the PR. I left some comments above.

Fanoid added 2 commits

August 22, 2023 11:49


          Improve readability of variables names, documents according to comments.

1d3b9c4


          Correct Python UT in BinaryClassificationEvaluatorTest.

5b7a073

Contributor Author

Fanoid commented Aug 22, 2023

@weibozhao Thanks for your comments. Would you please take another look?

Contributor

weibozhao commented Aug 24, 2023

Thanks for the update. LGTM overall.

Contributor Author

Fanoid commented Aug 24, 2023

hi, @zhipeng93 would you take an look on this PR?

zhipeng93 reviewed

View reviewed changes

...k-ml-lib/src/test/java/org/apache/flink/ml/evaluation/BinaryClassificationEvaluatorTest.java Outdated Show resolved Hide resolved


          Change 1e-9 to EPS in BinaryClassificationEvaluatorTest.

406378a

Contributor

zhipeng93 commented Aug 24, 2023

Thanks for the PR. LGTM.

zhipeng93 merged commit 5619c3b into apache:master

Fanoid deleted the FLINK-32889 branch

August 30, 2023 01:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet