Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-32285] Support multiple Flink versions in each Flink ML Java library release #240

Closed
wants to merge 2 commits into from
Closed

[FLINK-32285] Support multiple Flink versions in each Flink ML Java library release #240

wants to merge 2 commits into from
+2,896 −199

Conversation

jiangxin369
Copy link
Contributor

What is the purpose of the change

Support multiple Flink versions in each Flink ML Java library release. For now, we are making Flink ML works with Flink 1.15, 1.16, and 1.17.

Brief change log

  • Adds maven profiles to set the Flink version during the maven buiding.
  • For those classes that have compatibility issues with the default Flink version, reimplement them with the compatible Flink API. The reimplemented class should have the same fully qualified name but in a separate module to overwrite the default class.
  • Replaces all artifactId of the Jars to be published to maven central with Flink version bound.
  • Adds CI workflows to run Flink ML with all supported Flink version.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs)

@jiangxin369 jiangxin369 force-pushed the support-multi-versions branch 3 times, most recently from a6ea3f7 to 6fa3aa3 Compare June 9, 2023 05:17
@jiangxin369 jiangxin369 force-pushed the support-multi-versions branch from 6fa3aa3 to 325f0ff Compare June 9, 2023 06:18
@lindong28 lindong28 self-requested a review June 9, 2023 06:33
@jiangxin369 jiangxin369 force-pushed the support-multi-versions branch from 325f0ff to 180f8b0 Compare June 9, 2023 07:45
@lindong28
Copy link
Member

Thanks for the PR! LGTM.

@lindong28
Copy link
Member

Merged to apache/flink-ml master branch.

@lindong28 lindong28 closed this Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindong28 lindong28 Awaiting requested review from lindong28

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiangxin369 @lindong28