Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-31899] Upgrade Flink version of Flink ML to 1.17.0 #235

Merged
merged 1 commit into from
Apr 28, 2023
Merged

[FLINK-31899] Upgrade Flink version of Flink ML to 1.17.0 #235

merged 1 commit into from
Apr 28, 2023

Conversation

jiangxin369
Copy link
Contributor

@jiangxin369 jiangxin369 commented Apr 24, 2023 •
edited
Loading

What is the purpose of the change

Upgrade Flink version of Flink ML to 1.17.0.

Brief change log

Upgrade Flink version of Flink ML to 1.17.0. The main changes about compatibility are sd below.

  • 1.17 introduces CountingOutput which is used to update metrics, we need to adapt to it.
  • 1.17 upgrades the version of Py4j to 0.10.9.7, which introduces a bug, we have to change the way to call Java methods in Python temporarily.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@jiangxin369 jiangxin369 force-pushed the upgrade-flink-version-to-1.17 branch 6 times, most recently from c1915a8 to daf2bad Compare April 25, 2023 13:23
@jiangxin369 jiangxin369 marked this pull request as draft April 25, 2023 13:23
@jiangxin369 jiangxin369 force-pushed the upgrade-flink-version-to-1.17 branch from daf2bad to bc8122d Compare April 26, 2023 10:14
@jiangxin369 jiangxin369 marked this pull request as ready for review April 26, 2023 10:16
lindong28
lindong28 reviewed Apr 27, 2023
View reviewed changes
Copy link
Member

@lindong28 lindong28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Left some minor comments below.

@jiangxin369 jiangxin369 force-pushed the upgrade-flink-version-to-1.17 branch from 6cea166 to 51fbb3c Compare April 28, 2023 08:05
@jiangxin369
Copy link
Contributor Author

@lindong28 I've updated the PR, could you have another look?

@lindong28
Copy link
Member

Thanks for the update. LGTM.

@lindong28 lindong28 merged commit a5b7b49 into apache:master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindong28 lindong28 lindong28 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiangxin369 @lindong28