Fix missing Spring and OW2 attributions in shaded JAR - #1176
Open
skytin1004 wants to merge 2 commits into
Open
skytin1004 wants to merge 2 commits into
skytin1004 wants to merge 2 commits into
Conversation
Contributor
Author
|
I did another pass through the repository and found one additional copy of the ASM license in dist/licenses/LICENSE-asm.txt, which is included in the source release. I've added the missing OW2 attribution there as well. I also rebuilt the release artifacts and confirmed the updated license and notice files are included. I didn’t find any other missing copies. |
skytin1004
force-pushed
the
fix/shaded-license-attribution
branch
from
October 3, 2026 13:50
70bd704 to
989e479
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Closed: #1172
Add the missing copyright attribution for the Spring and ASM code bundled in
fesod-shaded, and keep the standalone ASM license used by the source distribution consistent.What's changed?
fesod-shaded'sMETA-INF/NOTICE.fesod-shaded'sMETA-INF/LICENSE.dist/licenses/LICENSE-asm.txt, which is included in the source release ZIP.spring-core5.3.39 license and preserved the existing LF/EOF style.Validation
./mvnw clean package -Papache-release -DskipTests -Dgpg.skip=true.spring-core5.3.39, with no Objenesis or unexpected third-party classes.git diff --checkand verified all three changed files use LF line endings.Checklist