Skip to content

fix: correct CSV metadata contract - #1165

Open
Aias00 wants to merge 1 commit into
apache:mainfrom
Aias00:fix/csv-metadata-contract-1155
Open

Aias00 wants to merge 1 commit into
apache:mainfrom
Aias00:fix/csv-metadata-contract-1155

Conversation

@Aias00

@Aias00 Aias00 commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Closed: #1155

Summary

  • report CSV sheet counts and iterators consistently after sheet creation
  • make physical row count non-negative and aligned with created rows

Verification

  • ./mvnw -pl fesod-sheet -Dmaven.test.skip=false -DskipTests=false -Dtest=CsvRowTest#csvSheetPhysicalRowCountShouldMatchCreatedRows+csvWorkbookShouldReportCreatedSheetThroughPoiMetadata test
  • ./mvnw -pl fesod-sheet spotless:check

Signed-off-by: liuhy <liuhongyu@apache.org>
@Aias00
Aias00 force-pushed the fix/csv-metadata-contract-1155 branch from 80fe562 to 17e7075 Compare September 30, 2026 07:04

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] CSV workbook metadata reports invalid row and sheet counts

1 participant