Skip to content

fix: treat numRows zero as unlimited - #1159

Open
Aias00 wants to merge 1 commit into
apache:mainfrom
Aias00:fix/numrows-zero-unlimited-1149
Open

Aias00 wants to merge 1 commit into
apache:mainfrom
Aias00:fix/numrows-zero-unlimited-1149

Conversation

@Aias00

@Aias00 Aias00 commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Closed: #1149

Summary

  • make numRows(0) follow the documented unlimited behavior
  • cover workbook-level and sheet-level numRows(0) reads across formats

Verification

  • ./mvnw -pl fesod-sheet -Dmaven.test.skip=false -DskipTests=false -Dtest=ParameterDataTest#numRowsZeroReadsAllRows test
  • ./mvnw -pl fesod-sheet spotless:check

Signed-off-by: liuhy <liuhongyu@apache.org>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] numRows(0) stops reading instead of disabling the row limit

1 participant