fix: fall back to default format index on malformed style index (#355)

fesod-sheet/src/main/java/org/apache/fesod/sheet/analysis/v07/handlers/CellTagHandler.java

@@ -74,7 +74,13 @@ public void startElement(XlsxReadContext xlsxReadContext, String name, Attribute
         if (StringUtils.isEmpty(dateFormatIndex)) {
             dateFormatIndexInteger = DEFAULT_FORMAT_INDEX;
         } else {
-            dateFormatIndexInteger = Integer.parseInt(dateFormatIndex);
+            try {
+                dateFormatIndexInteger = Integer.parseInt(dateFormatIndex);
+            } catch (NumberFormatException e) {
+                // A malformed style index (e.g. produced by third-party tools) must not abort the
+                // whole file read; fall back to the default format, matching POI's lenient behavior.
+                dateFormatIndexInteger = DEFAULT_FORMAT_INDEX;
+            }
         }
 
         xlsxReadSheetHolder

fesod-sheet/src/test/java/org/apache/fesod/sheet/analysis/v07/handlers/CellTagHandlerTest.java

@@ -20,8 +20,11 @@
 package org.apache.fesod.sheet.analysis.v07.handlers;
 
 import org.apache.fesod.sheet.context.xlsx.XlsxReadContext;
+import org.apache.fesod.sheet.enums.CellDataTypeEnum;
 import org.apache.fesod.sheet.exception.ExcelAnalysisException;
+import org.apache.fesod.sheet.metadata.data.ReadCellData;
 import org.apache.fesod.sheet.read.metadata.holder.xlsx.XlsxReadSheetHolder;
+import org.apache.fesod.sheet.read.metadata.holder.xlsx.XlsxReadWorkbookHolder;
 import org.apache.fesod.sheet.testkit.Tags;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Tag;
@@ -36,6 +39,10 @@
  * {@code null}, which then tripped the {@code ReadCellData} constructor with a confusing
  * {@code IllegalArgumentException: Type can not be null} that named neither the cell nor the attribute.
  * The handler must instead throw an {@link ExcelAnalysisException} naming the invalid type and its location.
+ *
+ * <p>Also covers <a href="https://github.com/apache/fesod/issues/355">issue #355</a>: a malformed
+ * {@code s} (style index) attribute used to abort the whole file read via a bare
+ * {@code Integer.parseInt}. The handler must fall back to the default format index instead.
  */
 @Tag(Tags.UNIT)
 class CellTagHandlerTest {
@@ -58,4 +65,46 @@ void startElement_throwsDescriptiveError_forUnknownCellType() {
         Assertions.assertTrue(message.contains("'unknown'"), "should name the unrecognized type: " + message);
         Assertions.assertTrue(message.contains("B4"), "should name the cell reference: " + message);
     }
+
+    @Test
+    void startElement_fallsBackToDefaultFormat_forMalformedStyleIndex() {
+        XlsxReadContext context = Mockito.mock(XlsxReadContext.class);
+        XlsxReadSheetHolder sheetHolder = Mockito.mock(XlsxReadSheetHolder.class);
+        XlsxReadWorkbookHolder workbookHolder = Mockito.mock(XlsxReadWorkbookHolder.class);
+        Mockito.when(context.xlsxReadSheetHolder()).thenReturn(sheetHolder);
+        Mockito.when(context.xlsxReadWorkbookHolder()).thenReturn(workbookHolder);
+        Mockito.when(sheetHolder.getTempCellData()).thenReturn(new ReadCellData<>(CellDataTypeEnum.NUMBER));
+
+        AttributesImpl attributes = new AttributesImpl();
+        attributes.addAttribute("", "r", "r", "CDATA", "B4");
+        attributes.addAttribute("", "t", "t", "CDATA", "n");
+        attributes.addAttribute("", "s", "s", "CDATA", "abc");
+
+        Assertions.assertDoesNotThrow(
+                () -> new CellTagHandler().startElement(context, "c", attributes),
+                "a malformed style index must not abort the read");
+
+        // The style lookup must fall back to the default format index (0) instead of parsing "abc".
+        Mockito.verify(workbookHolder).dataFormatData(0);
+    }
+
+    @Test
+    void startElement_usesStyleIndex_whenNumeric() {
+        XlsxReadContext context = Mockito.mock(XlsxReadContext.class);
+        XlsxReadSheetHolder sheetHolder = Mockito.mock(XlsxReadSheetHolder.class);
+        XlsxReadWorkbookHolder workbookHolder = Mockito.mock(XlsxReadWorkbookHolder.class);
+        Mockito.when(context.xlsxReadSheetHolder()).thenReturn(sheetHolder);
+        Mockito.when(context.xlsxReadWorkbookHolder()).thenReturn(workbookHolder);
+        Mockito.when(sheetHolder.getTempCellData()).thenReturn(new ReadCellData<>(CellDataTypeEnum.NUMBER));
+
+        AttributesImpl attributes = new AttributesImpl();
+        attributes.addAttribute("", "r", "r", "CDATA", "B4");
+        attributes.addAttribute("", "t", "t", "CDATA", "n");
+        attributes.addAttribute("", "s", "s", "CDATA", "3");
+
+        Assertions.assertDoesNotThrow(() -> new CellTagHandler().startElement(context, "c", attributes));
+
+        // Numeric style indices keep their exact lookup; the happy path is untouched.
+        Mockito.verify(workbookHolder).dataFormatData(3);
+    }
 }

fesod-sheet/src/test/java/org/apache/fesod/sheet/read/CorruptStyleIndexReadTest.java

@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.fesod.sheet.read;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.nio.charset.StandardCharsets;
+import java.util.List;
+import java.util.Map;
+import java.util.zip.ZipEntry;
+import java.util.zip.ZipOutputStream;
+import org.apache.fesod.sheet.FesodSheet;
+import org.apache.fesod.sheet.testkit.Tags;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Tag;
+import org.junit.jupiter.api.Test;
+
+/**
+ * Regression test for <a href="https://github.com/apache/fesod/issues/355">issue #355</a>.
+ *
+ * <p>An xlsx produced by third-party tools may carry a non-numeric {@code s} (style index)
+ * attribute on a cell. Reading such a file used to abort with a {@code NumberFormatException}
+ * at the very first corrupt cell, so nothing after it was read. The handler must fall back to
+ * the default format and keep reading the remaining rows.
+ *
+ * <p>The files below are hand-built minimal xlsx workbooks — one without styles.xml and one with a
+ * structurally complete styles.xml (one cellXf) — where row 1 and row 3 carry valid style indexes
+ * and row 2 carries a corrupt one. The variant with styles.xml mirrors the real-world scenario of
+ * the report: there POI's own streaming read aborts with the same {@code NumberFormatException},
+ * while fesod keeps reading.
+ */
+@Tag(Tags.READ)
+class CorruptStyleIndexReadTest {
+
+    private static final String CONTENT_TYPES = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?>\n"
+            + "<Types xmlns=\"http://schemas.openxmlformats.org/package/2006/content-types\">\n"
+            + "  <Default Extension=\"rels\" ContentType=\"application/vnd.openxmlformats-package.relationships+xml\"/>\n"
+            + "  <Default Extension=\"xml\" ContentType=\"application/xml\"/>\n"
+            + "  <Override PartName=\"/xl/workbook.xml\""
+            + " ContentType=\"application/vnd.openxmlformats-officedocument.spreadsheetml.sheet.main+xml\"/>\n"
+            + "  <Override PartName=\"/xl/worksheets/sheet1.xml\""
+            + " ContentType=\"application/vnd.openxmlformats-officedocument.spreadsheetml.worksheet+xml\"/>\n"
+            + "</Types>\n";
+
+    private static final String ROOT_RELS = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?>\n"
+            + "<Relationships xmlns=\"http://schemas.openxmlformats.org/package/2006/relationships\">\n"
+            + "  <Relationship Id=\"rId1\""
+            + " Type=\"http://schemas.openxmlformats.org/officeDocument/2006/relationships/officeDocument\""
+            + " Target=\"xl/workbook.xml\"/>\n"
+            + "</Relationships>\n";
+
+    private static final String WORKBOOK = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?>\n"
+            + "<workbook xmlns=\"http://schemas.openxmlformats.org/spreadsheetml/2006/main\""
+            + " xmlns:r=\"http://schemas.openxmlformats.org/officeDocument/2006/relationships\">\n"
+            + "  <sheets>\n"
+            + "    <sheet name=\"Sheet1\" sheetId=\"1\" r:id=\"rId1\"/>\n"
+            + "  </sheets>\n"
+            + "</workbook>\n";
+
+    private static final String WORKBOOK_RELS = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?>\n"
+            + "<Relationships xmlns=\"http://schemas.openxmlformats.org/package/2006/relationships\">\n"
+            + "  <Relationship Id=\"rId1\""
+            + " Type=\"http://schemas.openxmlformats.org/officeDocument/2006/relationships/worksheet\""
+            + " Target=\"worksheets/sheet1.xml\"/>\n"
+            + "</Relationships>\n";
+
+    private static final String CONTENT_TYPES_WITH_STYLES = CONTENT_TYPES.replace(
+            "</Types>",
+            "  <Override PartName=\"/xl/styles.xml\""
+                    + " ContentType=\"application/vnd.openxmlformats-officedocument.spreadsheetml.styles+xml\"/>\n"
+                    + "</Types>");
+
+    private static final String WORKBOOK_RELS_WITH_STYLES = WORKBOOK_RELS.replace(
+            "</Relationships>",
+            "  <Relationship Id=\"rId2\""
+                    + " Type=\"http://schemas.openxmlformats.org/officeDocument/2006/relationships/styles\""
+                    + " Target=\"styles.xml\"/>\n"
+                    + "</Relationships>");
+
+    /** Minimal but structurally complete styles.xml: a single "General" cellXf. */
+    private static final String STYLES = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?>\n"
+            + "<styleSheet xmlns=\"http://schemas.openxmlformats.org/spreadsheetml/2006/main\">\n"
+            + "  <fonts count=\"1\"><font><sz val=\"11\"/><name val=\"Calibri\"/></font></fonts>\n"
+            + "  <fills count=\"1\"><fill><patternFill patternType=\"none\"/></fill></fills>\n"
+            + "  <borders count=\"1\"><border/></borders>\n"
+            + "  <cellStyleXfs count=\"1\"><xf numFmtId=\"0\" fontId=\"0\" fillId=\"0\" borderId=\"0\"/></cellStyleXfs>\n"
+            + "  <cellXfs count=\"1\"><xf numFmtId=\"0\" fontId=\"0\" fillId=\"0\" borderId=\"0\" xfId=\"0\"/></cellXfs>\n"
+            + "  <cellStyles count=\"1\"><cellStyle name=\"Normal\" xfId=\"0\" builtinId=\"0\"/></cellStyles>\n"
+            + "</styleSheet>\n";
+
+    private static final String SHEET = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?>\n"
+            + "<worksheet xmlns=\"http://schemas.openxmlformats.org/spreadsheetml/2006/main\">\n"
+            + "  <sheetData>\n"
+            + "    <row r=\"1\"><c r=\"A1\" t=\"n\" s=\"0\"><v>1</v></c></row>\n"
+            + "    <row r=\"2\"><c r=\"A2\" t=\"n\" s=\"abc\"><v>2</v></c></row>\n"
+            + "    <row r=\"3\"><c r=\"A3\" t=\"n\" s=\"1\"><v>3</v></c></row>\n"
+            + "  </sheetData>\n"
+            + "</worksheet>\n";
+
+    @Test
+    void read_corruptStyleIndex_withoutStylesTable_readsAllRows() throws Exception {
+        File file = buildMinimalXlsx(false);
+
+        List<Map<Integer, String>> rows =
+                FesodSheet.read(file).sheet().headRowNumber(0).doReadSync();
+
+        Assertions.assertEquals(3, rows.size(), "all rows must be read, none aborted");
+        Assertions.assertEquals("1", rows.get(0).get(0));
+        Assertions.assertEquals("2", rows.get(1).get(0), "row with the corrupt style index must still be read");
+        Assertions.assertEquals("3", rows.get(2).get(0), "rows after the corrupt one must still be read");
+    }
+
+    @Test
+    void read_corruptStyleIndex_withStylesTable_readsAllRows() throws Exception {
+        File file = buildMinimalXlsx(true);
+
+        List<Map<Integer, String>> rows =
+                FesodSheet.read(file).sheet().headRowNumber(0).doReadSync();
+
+        Assertions.assertEquals(3, rows.size(), "all rows must be read, none aborted");
+        Assertions.assertEquals("1", rows.get(0).get(0));
+        Assertions.assertEquals("2", rows.get(1).get(0), "row with the corrupt style index must still be read");
+        Assertions.assertEquals("3", rows.get(2).get(0), "rows after the corrupt one must still be read");
+    }
+
+    private File buildMinimalXlsx(boolean withStyles) throws Exception {
+        File file = File.createTempFile("corrupt-style-index", ".xlsx");
+        try (ZipOutputStream zip = new ZipOutputStream(new FileOutputStream(file))) {
+            addEntry(zip, "[Content_Types].xml", withStyles ? CONTENT_TYPES_WITH_STYLES : CONTENT_TYPES);
+            addEntry(zip, "_rels/.rels", ROOT_RELS);
+            addEntry(zip, "xl/workbook.xml", WORKBOOK);
+            addEntry(zip, "xl/_rels/workbook.xml.rels", withStyles ? WORKBOOK_RELS_WITH_STYLES : WORKBOOK_RELS);
+            addEntry(zip, "xl/worksheets/sheet1.xml", SHEET);
+            if (withStyles) {
+                addEntry(zip, "xl/styles.xml", STYLES);
+            }
+        }
+        return file;
+    }
+
+    private void addEntry(ZipOutputStream zip, String name, String content) throws Exception {
+        zip.putNextEntry(new ZipEntry(name));
+        zip.write(content.getBytes(StandardCharsets.UTF_8));
+        zip.closeEntry();
+    }
+}