fixRegression: Fix the implementation of visualMap labels overlap. Fix #21586. #21637
Open
100pah wants to merge 1 commit into
Open
fixRegression: Fix the implementation of visualMap labels overlap. Fix #21586. #21637100pah wants to merge 1 commit into
100pah wants to merge 1 commit into
Conversation
…ode. (2). Remove the breaking change to `visualMap[type='continuous'].formatter: function () {}` - not necessary, and that breaking change can cause the existing lables display incorrectly when labels touch. (3). Switch to a more comprehensive implementation - adjust the positions of the two labels to avoid overlap. The previous approach (merging two labels) may occupy extra horizontal space and may unexpectedly cause overlap with other content. (4). Add visual test for `visualMap[type='continuous']`
|
Thanks for your contribution! The pull request is marked to be To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fix the implementation of #21586 .
Remove some verbose and unnecessary code.
Remove the breaking change to
visualMap[type='continuous'].formatter: function () {}- not necessary, and that breaking change can cause the existing lables display incorrectly when labels touch.The effect of fix(visualMap): prevent tooltip label overlap #21586 :
Expected:
Switch to a more comprehensive implementation - adjust the positions of the two labels to avoid overlap. The previous approach (merging two labels) may occupy extra horizontal space and may unexpectedly cause overlap with other content.
The effect of fix(visualMap): prevent tooltip label overlap #21586:
The effect of this PR:
Add visual test for
visualMap[type='continuous']