Merge pull request #20557 from apache/fix-pictorial

fix(pictorial): fix zero value flipping for different axes
apache · Dec 4, 2024 · b18ff75 · b18ff75
2 parents 592cab6 + 6e9ef3b
commit b18ff75
Show file tree

Hide file tree

Showing 2 changed files with 75 additions and 33 deletions.
diff --git a/src/chart/bar/PictorialBarView.ts b/src/chart/bar/PictorialBarView.ts
@@ -341,7 +341,11 @@ function prepareBarLength(
 
     // if 'pxSign' means sign of pixel,  it can't be zero, or symbolScale will be zero
     // and when borderWidth be settled, the actual linewidth will be NaN
-    outputSymbolMeta.pxSign = boundingLength >= 0 ? 1 : -1;
+    const isXAxis = valueDim.xy === 'x';
+    const isInverse = valueAxis.inverse;
+    outputSymbolMeta.pxSign = (isXAxis && !isInverse) || (!isXAxis && isInverse)
+        ? boundingLength >= 0 ? 1 : -1
+        : boundingLength > 0 ? 1 : -1;
 }
 
 function convertToCoordOnAxis(axis: Axis2D, value: number) {

diff --git a/test/pictorial-zero-value.html b/test/pictorial-zero-value.html