Skip to content

Commit

Permalink
Merge pull request #17247 from apache/fix/tmp-symbol-z
Browse files Browse the repository at this point in the history
fix(line): set default z/zlevel for temporary symbol to avoid warnings.
  • Loading branch information
plainheart authored Jun 20, 2022
2 parents 0f9f16c + 6212121 commit 26fbb75
Show file tree
Hide file tree
Showing 4 changed files with 39 additions and 5 deletions.
4 changes: 2 additions & 2 deletions src/chart/line/LineView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -947,8 +947,8 @@ class LineView extends ChartView {
if (this._clipShapeForSymbol && !this._clipShapeForSymbol.contain(x, y)) {
return;
}
const zlevel = seriesModel.get('zlevel');
const z = seriesModel.get('z');
const zlevel = seriesModel.get('zlevel') || 0;
const z = seriesModel.get('z') || 0;
symbol = new SymbolClz(data, dataIndex);
symbol.x = x;
symbol.y = y;
Expand Down
34 changes: 34 additions & 0 deletions test/line-case.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions test/runTest/actions/__meta__.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/runTest/actions/line-case.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 26fbb75

Please sign in to comment.