refactor: use AsyncResource instead of Future to acquire segment references - #20197
Draft
clintropolis wants to merge 1 commit into
Draft
refactor: use AsyncResource instead of Future to acquire segment references#20197clintropolis wants to merge 1 commit into
clintropolis wants to merge 1 commit into
Conversation
github-actions
Bot
added
Area - Batch Ingestion
Area - Segment Format and Ser/De
Area - Ingestion
Area - MSQ
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // AcquireSegmentAction currently doesn't have a meaningful toString method, so if this message | ||
| // ever actually gets logged, it won't mention the specific segment that had a problem. Perhaps | ||
| // one day this will change. | ||
| e -> log.warn(e, "Failed to close loadingSegment[%s]", acquireSegmentAction) |
|
|
||
| private DataSegment makeSegment(String name) | ||
| { | ||
| return DataSegment.builder() |
| .loadSpec(ImmutableMap.of("type", "gated", "size", (int) SEGMENT_SIZE, "name", name)) | ||
| .dimensions(ImmutableList.of()) | ||
| .metrics(ImmutableList.of()) | ||
| .shardSpec(new NumberedShardSpec(Integer.parseInt(name.substring(name.length() - 1)), 0)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Exploration in replacing Future with AsyncResource for acquiring segment references and MSQ processing.