feat: separate worker disabled state from worker version#19448
Open
jtuglu1 wants to merge 1 commit into
Open
Conversation
jtuglu1
force-pushed
the
separate-disabled-flag-from-worker-version
branch
from
313e2b8 to
dfb03f5
Compare
jtuglu1
force-pushed
the
separate-disabled-flag-from-worker-version
branch
from
dfb03f5 to
b8655f2
Compare
Member
FrankChen021
left a comment
FrankChen021
left a comment
There was a problem hiding this comment.
I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.
Reviewed 10 of 10 changed files.
This is an automated review by Codex GPT-5.5
abhishekrb19
approved these changes
May 12, 2026
Contributor
abhishekrb19
left a comment
abhishekrb19
left a comment
There was a problem hiding this comment.
Lgtm, left some minor comments.
jtuglu1
force-pushed
the
separate-disabled-flag-from-worker-version
branch
from
b8655f2 to
0a105a7
Compare
Member
FrankChen021
left a comment
FrankChen021
left a comment
There was a problem hiding this comment.
| Severity | Findings |
|---|---|
| P0 | 0 |
| P1 | 0 |
| P2 | 1 |
| P3 | 0 |
| Total | 1 |
Reviewed 10 of 10 changed files.
This is an automated review by Codex GPT-5.5
jtuglu1
force-pushed
the
separate-disabled-flag-from-worker-version
branch
from
0a105a7 to
3df0de7
Compare
jtuglu1
force-pushed
the
separate-disabled-flag-from-worker-version
branch
from
3df0de7 to
bda80a9
Compare
jtuglu1
force-pushed
the
separate-disabled-flag-from-worker-version
branch
from
bda80a9 to
287ff18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, to disable a worker (MM/Indexer), you need to set the version as
"". This is not ideal, as it's difficult to see a) what version a disabled worker is and b) write any logic to perform scaling around multi-version worker deployments (for example during a rolling upgrade).This ensures the disabled state is tracked separately from the worker version. The change is backwards compatible (to not break existing deployments) and can then be migrated to simply relying on the
disabledflag in a subsequent release.Release note
Track the worker enabled state separately from the worker version.
This PR has: