Skip to content

fix: Added missing statsd mappings, updated mappings dimensions and metrics docs to reflect the emitted Coordinator stats#19392

Open
pirvtech wants to merge 2 commits into
apache:masterfrom
RivianVW-tech:statsd-metrics-backlog
Open

fix: Added missing statsd mappings, updated mappings dimensions and metrics docs to reflect the emitted Coordinator stats#19392
pirvtech wants to merge 2 commits into
apache:masterfrom
RivianVW-tech:statsd-metrics-backlog

Conversation

@pirvtech
Copy link
Copy Markdown

@pirvtech pirvtech commented Apr 30, 2026

Description

Metrics published by various Druid services are handled by the configured Emitter to send them to external observability systems. The Statsd Emitter is used to send to StatsD system. This emitter uses a default mapping file (packaged within Druid) to map from Druid metric types to StatsD metric types. If a mapping is not present for a metric, it is not emitted.

A number of metrics are missing mappings or have incomplete or incorrect dimensions specified in the mappings. It is likely because these mappings are not being kept up-to-date, with the additions and changes to published metrics in the code.

This change updates these mappings for Coordinator metrics and fixes documentation where it deviates from what is in the code.

Release note


Fixes missing Coordinator stats not being published to StatsD system

This PR has:

  • [ x] been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

…s docs to reflect the emitted Coordinator stats
Copy link
Copy Markdown
Member

@FrankChen021 FrankChen021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Severity Findings
P0 0
P1 0
P2 3
P3 0
Total 3

This is an automated review by Codex GPT-5

Comment thread extensions-contrib/statsd-emitter/src/main/resources/defaultMetricDimensions.json Outdated
Comment thread extensions-contrib/statsd-emitter/src/main/resources/defaultMetricDimensions.json Outdated
Comment thread extensions-contrib/statsd-emitter/src/main/resources/defaultMetricDimensions.json Outdated
Copy link
Copy Markdown
Member

@FrankChen021 FrankChen021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the follow-up changes. All three prior statsd mapping threads appear resolved in the current code: clone-drop keeps the emitted server dimension, cancelled compaction tasks keep dataSource, and broker sync metrics include their emitted configType and server dimensions.


This is an automated review by Codex GPT-5

@pirvtech pirvtech changed the title Added missing statsd mappings, updated mappings dimensions and metrics docs to reflect the emitted Coordinator stats fix: Added missing statsd mappings, updated mappings dimensions and metrics docs to reflect the emitted Coordinator stats May 11, 2026
@pirvtech
Copy link
Copy Markdown
Author

Any other comments or is it good to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants