fix vsf bug when restoring entries on a failed reclaim#19160
Merged
clintropolis merged 2 commits intoapache:masterfrom Mar 16, 2026
Merged
fix vsf bug when restoring entries on a failed reclaim#19160clintropolis merged 2 commits intoapache:masterfrom
clintropolis merged 2 commits intoapache:masterfrom
Conversation
gianm
approved these changes
Mar 15, 2026
| ); | ||
|
|
||
| // must free 20 bytes but can only evict entry1 (10). Fails and restores entry1 | ||
| // where the bug was a mistmatch caused by creating a new entry in the list but re-using the old entry for the map. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in
StorageLocationcaused by a mismatch of using a newWeakCacheEntryin the doubly linked list but re-using the existing entry in the map, resulting in a defensive exception that is supposed to be impossible. The map entry is what is used for unlinking, but its the re-used entry which has already been nulled out, leaving the new entry in the list.