Skip to content

gha should not ignore flaky failure#19134

Open
cecemei wants to merge 9 commits intoapache:masterfrom
cecemei:gha3.1
Open

gha should not ignore flaky failure#19134
cecemei wants to merge 9 commits intoapache:masterfrom
cecemei:gha3.1

Conversation

@cecemei
Copy link
Contributor

@cecemei cecemei commented Mar 11, 2026

gha should not ignore flaky failure, see example run converts flaky failures to actual failures and fails the run. For parameterized tests, is not reliable. It can hide real failures because the reporter treats intermittent or partial failures as “flaky” for the entire method.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@github-actions github-actions bot added Area - Batch Ingestion Area - Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 GHA labels Mar 11, 2026
@cecemei cecemei changed the title Gha3.1 gha should not ignore flaky failure Mar 12, 2026
@cecemei cecemei marked this pull request as ready for review March 12, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area - Batch Ingestion Area - Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 GHA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant