Improve extensibility of MSQ Dart engine via extensions#19127
Open
kfaraz wants to merge 3 commits intoapache:masterfrom
Open
Improve extensibility of MSQ Dart engine via extensions#19127kfaraz wants to merge 3 commits intoapache:masterfrom
kfaraz wants to merge 3 commits intoapache:masterfrom
Conversation
github-actions
bot
added
Area - Batch Ingestion
Area - Ingestion
Area - MSQ
gianm
reviewed
Mar 13, 2026
Contributor
gianm
left a comment
gianm
left a comment
There was a problem hiding this comment.
Generally LGTM. One thing looked suspicious.
| public DruidNodeDiscovery getForServiceAndRoles(String serviceName, Set<NodeRole> nodeRolesToWatch) | ||
| { | ||
| return serviceDiscoveryMap.computeIfAbsent( | ||
| serviceName, |
Contributor
There was a problem hiding this comment.
Shouldn't the key of this map now be a combination of serviceName and nodeRolesToWatch? Otherwise, if this method is called more than once for the same service with different roles, the subsequent callers won't get the correct roles.
Contributor
Author
There was a problem hiding this comment.
Thanks for catching this! Fixed.
Contributor
Author
|
The flaky |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a collection of minor refactors that help extensions use and override certain Dart capabilities.
Changes
ServletResourceUtils.createAsyncTimeoutListenerThis PR has: