add thrift inputformat implementation#19111
Merged
clintropolis merged 6 commits intoapache:masterfrom Mar 10, 2026
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| try { | ||
| final Class<TBase> clazz = getThriftClass(); | ||
| final TBase tbase = clazz.newInstance(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| clazz = (Class<TBase>) Class.forName(thriftClassName); | ||
| } | ||
| // Verify the class can be instantiated | ||
| clazz.newInstance(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
kfaraz
approved these changes
Mar 9, 2026
| @JsonCreator | ||
| public ThriftInputFormat( | ||
| @JsonProperty("flattenSpec") @Nullable JSONPathSpec flattenSpec, | ||
| @JsonProperty("thriftJar") @Nullable String jarPath, |
Contributor
There was a problem hiding this comment.
Nit: Best to align the field/argument name with the json property name.
GWphua
pushed a commit
to GWphua/druid
that referenced
this pull request
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a thrift
InputFormatimplementation, which I believe is the last data format extension which has not implementedInputFormat. This PR coupled with #19109, will allow us to remove all operator facingInputRowParser/ParseSpecimplementations.I had claude do most of the work here since its perfect for this kind of thing, with a few manual adjustments at the end.