[chore](auth) Fix mislabeled log strings and remove debug main in authorization plugin path#65739
Open
arpitjain099 wants to merge 1 commit into
Open
[chore](auth) Fix mislabeled log strings and remove debug main in authorization plugin path#65739arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
…horization plugin path Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Small tidy-ups I noticed while reading through the authorization plugin path (
AccessControllerManagerand the Ranger controller) for the OpenFGA work.Two things:
AccessControllerManager.loadAccessControllerPlugins()the two log/exception strings for the classpath loader say "Authentication Plugin Factories", but this method loadsAccessControllerFactoryinstances (authorization). The directory loader a few lines down already logs "Access Controller Plugin Factory", so this just makes the classpath branch consistent and stops the messages from pointing a reader at the wrong subsystem. The class javadoc also called the manager the entry point of "privilege authentication"; corrected to "authorization".RangerDorisAccessControllerstill carries a leftoverpublic static void mainmarked "For test only" that constructs a controller and prints to stdout. It is dead code (nothing references it, and it is not a real test) so I removed it.No behavior change, log wording and a dead method only.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
I'll keep looking at where I can help Doris support different authentication and authorization systems as I go.