Skip to content

fix(nereids): prevent implicit BigInt/LargeInt to Double cast in join… #63054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leonard9893 wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −0
Open

fix(nereids): prevent implicit BigInt/LargeInt to Double cast in join… #63054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions fe/fe-core/src/main/java/org/apache/doris/nereids/util/TypeCoercionUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,6 +1033,15 @@ private static Optional<DataType> getCommonDataTypeWithFloatNumericType(DataType
|| rightType instanceof SmallIntType) {
return Optional.of(leftType);
}
// For BigIntType and LargeIntType, using DoubleType would lose precision
// because double only has 53 bits of mantissa (about 15-17 significant digits).
// BigInt can represent up to 19 digits, and LargeInt up to 39 digits.
// Use DecimalV3Type to preserve exact integer representation.
if (rightType instanceof BigIntType || rightType instanceof LargeIntType) {
return Optional.of(DecimalV3Type.widerDecimalV3Type(
DecimalV3Type.forType(leftType),
DecimalV3Type.forType(rightType), true));
}
return Optional.of(DoubleType.INSTANCE);
}

Expand Down Expand Up @@ -1758,6 +1767,16 @@ private static Optional<DataType> findCommonPrimitiveTypeForComparison(
// numeric
if (leftType.isFloatType() || leftType.isDoubleType()
|| rightType.isFloatType() || rightType.isDoubleType()) {
// For BigIntType and LargeIntType, using DoubleType loses precision
// because double only has 53 bits of mantissa (~15-17 significant digits).
// BigInt can represent up to 19 digits, and LargeInt up to 39 digits.
// Use DecimalV3Type to preserve exact integer representation.
if (leftType instanceof BigIntType || leftType instanceof LargeIntType
|| rightType instanceof BigIntType || rightType instanceof LargeIntType) {
return Optional.of(DecimalV3Type.widerDecimalV3Type(
DecimalV3Type.forType(leftType),
DecimalV3Type.forType(rightType), true));
}
return Optional.of(DoubleType.INSTANCE);
}
if (leftType.isNumericType() && rightType.isNumericType()) {
Expand Down
Loading