Skip to content

[fix] (storage) Fix pointer dereference bug in LocalFileSystem::list_impl#60907

Open
xuchenhao wants to merge 1 commit intoapache:masterfrom
HYDCP:fix-pointer-check
Open

[fix] (storage) Fix pointer dereference bug in LocalFileSystem::list_impl#60907
xuchenhao wants to merge 1 commit intoapache:masterfrom
HYDCP:fix-pointer-check

Conversation

@xuchenhao
Copy link
Contributor

@xuchenhao xuchenhao commented Feb 28, 2026

What problem does this PR solve?

Issue Number: close #60904

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@xuchenhao
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 29110 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d335f7da7036bd1cbabc61ce1028b1ed4e2c0851, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17596	4515	4337	4337
q2	q3	10657	818	558	558
q4	4704	374	246	246
q5	7778	1209	1033	1033
q6	211	173	151	151
q7	801	846	667	667
q8	10553	1505	1343	1343
q9	6095	4787	4709	4709
q10	6864	1897	1634	1634
q11	453	266	242	242
q12	742	564	461	461
q13	17778	4241	3442	3442
q14	235	229	211	211
q15	942	792	799	792
q16	744	721	690	690
q17	749	844	428	428
q18	5985	5314	5245	5245
q19	1201	993	648	648
q20	511	493	555	493
q21	4539	1941	1514	1514
q22	380	308	266	266
Total cold run time: 99518 ms
Total hot run time: 29110 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4859	4652	4641	4641
q2	q3	1861	2281	1814	1814
q4	888	1186	754	754
q5	4041	4501	4407	4407
q6	176	175	146	146
q7	1771	1667	1525	1525
q8	2512	2777	2526	2526
q9	7537	7440	7331	7331
q10	2617	2861	2393	2393
q11	509	429	404	404
q12	577	643	452	452
q13	4111	4486	3587	3587
q14	278	304	287	287
q15	853	825	837	825
q16	709	763	722	722
q17	1207	1566	1312	1312
q18	7296	6894	6628	6628
q19	871	914	945	914
q20	2047	2168	2010	2010
q21	4006	3411	3550	3411
q22	473	451	380	380
Total cold run time: 49199 ms
Total hot run time: 46469 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184082 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d335f7da7036bd1cbabc61ce1028b1ed4e2c0851, data reload: false

query5	4331	638	515	515
query6	338	218	199	199
query7	4202	478	265	265
query8	347	241	248	241
query9	8748	2715	2740	2715
query10	512	380	347	347
query11	17013	17588	17268	17268
query12	205	174	145	145
query13	1296	487	360	360
query14	6715	3288	3043	3043
query14_1	2949	2876	2929	2876
query15	216	195	199	195
query16	4890	491	451	451
query17	1422	732	617	617
query18	2347	434	377	377
query19	220	222	181	181
query20	159	130	122	122
query21	212	143	121	121
query22	5640	5327	5078	5078
query23	17218	16764	16547	16547
query23_1	16719	16576	16688	16576
query24	7374	1614	1204	1204
query24_1	1210	1229	1229	1229
query25	528	465	405	405
query26	1203	261	180	180
query27	2732	492	279	279
query28	4473	1890	1900	1890
query29	739	567	460	460
query30	305	248	212	212
query31	870	717	640	640
query32	82	75	74	74
query33	512	349	278	278
query34	914	925	542	542
query35	627	676	598	598
query36	1083	1152	1020	1020
query37	130	94	92	92
query38	2960	2945	2879	2879
query39	1020	889	851	851
query39_1	828	845	867	845
query40	234	150	140	140
query41	63	69	58	58
query42	110	103	100	100
query43	371	381	356	356
query44	
query45	205	189	184	184
query46	873	980	607	607
query47	2118	2124	2046	2046
query48	304	330	228	228
query49	618	488	377	377
query50	688	314	212	212
query51	4105	4114	4057	4057
query52	105	108	95	95
query53	292	337	282	282
query54	300	274	255	255
query55	87	86	88	86
query56	301	313	300	300
query57	1385	1338	1273	1273
query58	286	276	274	274
query59	2544	2662	2520	2520
query60	345	338	320	320
query61	144	150	145	145
query62	620	581	561	561
query63	318	277	272	272
query64	4419	1237	991	991
query65	
query66	1303	440	354	354
query67	16312	16373	16322	16322
query68	
query69	392	308	273	273
query70	990	976	957	957
query71	326	297	297	297
query72	2820	2946	2532	2532
query73	550	547	323	323
query74	10007	9941	9775	9775
query75	2874	2768	2473	2473
query76	1863	1042	695	695
query77	399	403	312	312
query78	11236	11384	10756	10756
query79	2573	805	592	592
query80	1728	644	558	558
query81	571	284	253	253
query82	999	154	119	119
query83	332	293	243	243
query84	252	120	97	97
query85	891	483	431	431
query86	415	307	333	307
query87	3122	3084	3038	3038
query88	3502	2629	2649	2629
query89	418	373	347	347
query90	1966	170	166	166
query91	152	155	132	132
query92	77	78	68	68
query93	1117	837	508	508
query94	624	321	292	292
query95	579	395	317	317
query96	646	521	226	226
query97	2480	2493	2434	2434
query98	227	221	222	221
query99	995	978	940	940
Total cold run time: 258291 ms
Total hot run time: 184082 ms

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.53% (19581/37275)
Line Coverage 36.16% (182807/505489)
Region Coverage 32.51% (142015/436786)
Branch Coverage 33.47% (61557/183913)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.42% (26117/36567)
Line Coverage 54.24% (273825/504856)
Region Coverage 51.43% (227163/441719)
Branch Coverage 52.82% (97671/184928)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Spill GC crashes due to missing pointer dereference in LocalFileSystem::list_impl

3 participants