[feat](iceberg) support aliyun dlf iceberg rest catalog#60796
Open
morningman wants to merge 16 commits intoapache:masterfrom
Open
[feat](iceberg) support aliyun dlf iceberg rest catalog#60796morningman wants to merge 16 commits intoapache:masterfrom
morningman wants to merge 16 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 28652 ms |
TPC-DS: Total hot run time: 183465 ms |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
morningman
force-pushed
the
wt-dlf-iceberg
branch
3 times, most recently
from
0087590 to
a8411a5
Compare
CalvinKirs
reviewed
Feb 26, 2026
Comment on lines
191
to
197
|
|
||
| protected void tryAddingIOImpl(Map<String, String> options) { | ||
| if (!Strings.isNullOrEmpty(ioImpl)) { | ||
| options.put(CatalogProperties.FILE_IO_IMPL, ioImpl); | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
This should be built centrally in the base class, rather than making every subclass implement it.
morningman
force-pushed
the
wt-dlf-iceberg
branch
from
a8411a5 to
4c1391f
Compare
CalvinKirs
previously approved these changes
Feb 27, 2026
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morningman
force-pushed
the
wt-dlf-iceberg
branch
from
9004e37 to
9bcee28
Compare
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 28792 ms |
TPC-DS: Total hot run time: 184148 ms |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 28880 ms |
TPC-DS: Total hot run time: 184155 ms |
Contributor
FE UT Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
depends on #60856
Support Aliyun DLF (Data Lake Formation) as an Iceberg REST catalog.
Main changes:
rest.signing-name, so names like "DlfNext" work correctly.properties are returned from iceberg rest catalog, to avoid
incorrectly using S3 credentials for non-S3 storage (e.g. OSS).
that only delegates to super.
StoragePropertiesTest for DLF REST catalog integration and property
resolution testing.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)