[[fix](rest-s3)Set AWS Request Checksum Calculation only if not set void issues on non-S3 storage #58467
+40
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
…void issues on non-S3 storage AWS SDK for Java v2 uses the system property AwsSystemSetting.AWS_REQUEST_CHECKSUM_CALCULATION to control request payload checksum calculation. According to the official discussion AWS SDK v2 Discussion apache#5802 : By default, the SDK may automatically calculate checksums when required. For AWS S3, setting the default value "WHEN_REQUIRED" ensures checksums are calculated only when necessary, providing both compatibility and performance benefits. aws-chunked encoding is not supported with the specified x-amz-content-sha256 value because these services do not support AWS-specific chunked encoding or SHA256 checksum.
CalvinKirs
force-pushed
the
master-rest-s3
branch
from
d5e6e1e to
5251cb7
Compare
Member
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
TPC-H: Total hot run time: 35039 ms |
TPC-DS: Total hot run time: 184661 ms |
ClickBench: Total hot run time: 27.31 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
zy-kkk
approved these changes
Nov 28, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Nov 28, 2025
…oid issues on non-S3 storage (#58467) AWS SDK for Java v2 uses the system property AwsSystemSetting.AWS_REQUEST_CHECKSUM_CALCULATION to control request payload checksum calculation. According to the official discussion AWS SDK v2 Discussion aws/aws-sdk-java-v2#5802 By default, the SDK may automatically calculate checksums when required. For AWS S3, setting the default value "WHEN_REQUIRED" ensures checksums are calculated only when necessary, providing both compatibility and performance benefits. For non-S3 object storage (such as COS, OSS, OBS), using this default value may cause errors, for example: `aws-chunked encoding is not supported with the specified x-amz-content-sha256 value` because these services do not support AWS-specific chunked encoding or SHA256 checksum.
CalvinKirs
added a commit
to CalvinKirs/incubator-doris
that referenced
this pull request
Dec 1, 2025
…f not set void issues on non-S3 storage (apache#58467) apache#58467
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS SDK for Java v2 uses the system property AwsSystemSetting.AWS_REQUEST_CHECKSUM_CALCULATION to control request payload checksum calculation.
According to the official discussion AWS SDK v2 Discussion aws/aws-sdk-java-v2#5802
By default, the SDK may automatically calculate checksums when required.
For AWS S3, setting the default value "WHEN_REQUIRED" ensures checksums are calculated only when necessary, providing both compatibility and performance benefits.
For non-S3 object storage (such as COS, OSS, OBS), using this default value may cause errors, for example:
aws-chunked encoding is not supported with the specified x-amz-content-sha256 valuebecause these services do not support AWS-specific chunked encoding or SHA256 checksum.