Skip to content

Conversation

@HappenLee
Copy link
Contributor

What problem does this PR solve?

Support in filter do digest cal to enable condition cache

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Nov 27, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@HappenLee
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34571 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8a9e8e6f8ee6214dc39b0bcca4f96cdfd83c8f4e, data reload: false

------ Round 1 ----------------------------------
q1	17614	5024	4984	4984
q2	2039	346	208	208
q3	10213	1288	754	754
q4	10241	972	396	396
q5	7478	2383	2396	2383
q6	188	181	145	145
q7	947	789	637	637
q8	9352	1369	1203	1203
q9	7227	5360	5326	5326
q10	6910	2235	1846	1846
q11	512	310	289	289
q12	361	378	243	243
q13	17809	3743	3043	3043
q14	236	237	214	214
q15	590	511	507	507
q16	1038	1048	958	958
q17	591	883	346	346
q18	7505	7253	7037	7037
q19	1358	967	557	557
q20	393	357	220	220
q21	3711	3204	2309	2309
q22	1049	999	966	966
Total cold run time: 107362 ms
Total hot run time: 34571 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5016	4995	5001	4995
q2	322	393	313	313
q3	2202	2682	2330	2330
q4	1375	1763	1313	1313
q5	4237	4633	4591	4591
q6	220	181	133	133
q7	2096	2001	1844	1844
q8	2663	2573	2540	2540
q9	7528	7509	7572	7509
q10	3129	3237	2876	2876
q11	608	551	493	493
q12	701	820	650	650
q13	3567	3938	3333	3333
q14	311	307	296	296
q15	553	521	536	521
q16	1138	1107	1101	1101
q17	1195	1544	1434	1434
q18	7928	7760	7574	7574
q19	791	785	931	785
q20	2000	2112	1902	1902
q21	5087	4457	4202	4202
q22	1084	1070	998	998
Total cold run time: 53751 ms
Total hot run time: 51733 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 183211 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8a9e8e6f8ee6214dc39b0bcca4f96cdfd83c8f4e, data reload: false

query1	1062	444	387	387
query2	6556	1623	1575	1575
query3	6760	112	107	107
query4	25504	22995	22503	22503
query5	4377	631	497	497
query6	337	231	203	203
query7	4678	470	274	274
query8	298	274	247	247
query9	8688	2621	2622	2621
query10	530	332	285	285
query11	15065	15509	14615	14615
query12	175	121	113	113
query13	1709	489	374	374
query14	11092	9103	9074	9074
query15	228	207	188	188
query16	7570	505	461	461
query17	1263	746	615	615
query18	2032	462	347	347
query19	216	197	180	180
query20	137	126	125	125
query21	218	144	116	116
query22	3886	4111	3878	3878
query23	33401	32101	32112	32101
query24	8874	2431	2467	2431
query25	629	500	448	448
query26	1245	281	172	172
query27	2911	457	319	319
query28	4419	2161	2141	2141
query29	858	588	500	500
query30	313	244	217	217
query31	892	728	641	641
query32	85	75	70	70
query33	667	358	356	356
query34	827	903	548	548
query35	826	838	729	729
query36	922	940	857	857
query37	120	90	76	76
query38	3326	3322	3277	3277
query39	1488	1406	1419	1406
query40	219	130	118	118
query41	64	61	65	61
query42	129	100	105	100
query43	446	457	411	411
query44	1221	756	758	756
query45	199	191	186	186
query46	898	961	599	599
query47	1688	1702	1606	1606
query48	394	336	242	242
query49	783	439	359	359
query50	653	290	226	226
query51	3909	3982	3863	3863
query52	119	100	86	86
query53	238	245	188	188
query54	325	255	234	234
query55	99	79	74	74
query56	337	283	311	283
query57	1182	1150	1074	1074
query58	285	253	263	253
query59	2455	2575	2411	2411
query60	379	320	300	300
query61	162	155	160	155
query62	779	685	638	638
query63	227	175	188	175
query64	4508	1147	926	926
query65	4098	4000	3992	3992
query66	1214	436	333	333
query67	15517	15255	14893	14893
query68	8324	868	647	647
query69	500	295	266	266
query70	1341	1217	1182	1182
query71	479	293	273	273
query72	6061	5136	5047	5047
query73	699	595	306	306
query74	8679	8589	8566	8566
query75	3986	3342	2888	2888
query76	3638	1134	722	722
query77	820	391	298	298
query78	9739	9614	8898	8898
query79	1823	847	593	593
query80	683	536	463	463
query81	504	276	239	239
query82	479	154	130	130
query83	283	269	259	259
query84	263	117	100	100
query85	977	486	461	461
query86	395	297	287	287
query87	3507	3546	3407	3407
query88	3804	2132	2154	2132
query89	394	316	287	287
query90	2012	166	169	166
query91	177	174	145	145
query92	87	68	60	60
query93	2000	1005	657	657
query94	749	323	293	293
query95	572	373	320	320
query96	511	536	228	228
query97	2916	2975	2843	2843
query98	244	203	207	203
query99	1362	1346	1229	1229
Total cold run time: 274719 ms
Total hot run time: 183211 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.92 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8a9e8e6f8ee6214dc39b0bcca4f96cdfd83c8f4e, data reload: false

query1	0.06	0.05	0.06
query2	0.10	0.05	0.05
query3	0.26	0.08	0.09
query4	1.60	0.11	0.11
query5	0.26	0.26	0.26
query6	1.17	0.65	0.64
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.58	0.53	0.52
query10	0.58	0.59	0.57
query11	0.17	0.11	0.12
query12	0.15	0.12	0.12
query13	0.64	0.61	0.61
query14	1.01	1.01	1.01
query15	0.85	0.84	0.84
query16	0.38	0.39	0.39
query17	1.07	1.00	1.03
query18	0.22	0.21	0.20
query19	1.92	1.89	1.82
query20	0.02	0.01	0.02
query21	15.47	0.21	0.13
query22	4.97	0.07	0.04
query23	15.66	0.28	0.10
query24	2.58	0.74	0.74
query25	0.09	0.06	0.06
query26	0.15	0.15	0.14
query27	0.08	0.06	0.06
query28	4.46	1.17	0.94
query29	12.57	3.90	3.23
query30	0.28	0.13	0.11
query31	2.82	0.60	0.39
query32	3.24	0.57	0.49
query33	3.08	3.03	3.15
query34	15.96	5.18	4.57
query35	4.58	4.60	4.62
query36	0.66	0.50	0.49
query37	0.11	0.06	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.15	0.14
query41	0.08	0.04	0.03
query42	0.05	0.04	0.02
query43	0.05	0.03	0.04
Total cold run time: 98.33 s
Total hot run time: 27.92 s

Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 27, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/30) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.88% (18503/34988)
Line Coverage 38.43% (169484/441075)
Region Coverage 33.24% (131604/395959)
Branch Coverage 34.18% (56662/165773)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 73.33% (22/30) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.63% (24564/34294)
Line Coverage 58.16% (256144/440450)
Region Coverage 53.25% (213335/400649)
Branch Coverage 54.73% (91160/166578)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants