Skip to content

[Chore][API] Remove deprecated ProjectService#checkProjectAndAuth#18218

Merged
ruanwenjun merged 1 commit intoapache:devfrom
ruanwenjun:refactor-api-replace-deprecated-checkProjectAndAuth
May 7, 2026
Merged

[Chore][API] Remove deprecated ProjectService#checkProjectAndAuth#18218
ruanwenjun merged 1 commit intoapache:devfrom
ruanwenjun:refactor-api-replace-deprecated-checkProjectAndAuth

Conversation

@ruanwenjun
Copy link
Copy Markdown
Member

Was this PR generated or assisted by AI?

YES, ops 4.7

Purpose of the pull request

Migrate all internal callers to checkProjectAndAuthThrowException and drop the two @deprecated overloads (Map-returning and Result-mutating) along with the unused private getCheckResult helper. Tests are updated to mock the new throwing API via doThrow / doNothing and assert exceptions instead of inspecting result-map status codes. Permission failures now flow through ApiExceptionHandler, preserving the wire format.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@ruanwenjun ruanwenjun force-pushed the refactor-api-replace-deprecated-checkProjectAndAuth branch from 103fbba to 090608c Compare May 7, 2026 01:58
@ruanwenjun ruanwenjun added this to the 3.4.2 milestone May 7, 2026
Migrate all internal callers to checkProjectAndAuthThrowException and drop
the two @deprecated overloads (Map-returning and Result-mutating) along
with the unused private getCheckResult helper. Tests are updated to mock
the new throwing API via doThrow / doNothing and assert exceptions
instead of inspecting result-map status codes. Permission failures now
flow through ApiExceptionHandler, preserving the wire format.
@ruanwenjun ruanwenjun force-pushed the refactor-api-replace-deprecated-checkProjectAndAuth branch from 090608c to a2fa155 Compare May 7, 2026 11:53
@SbloodyS SbloodyS added the chore label May 7, 2026
Copy link
Copy Markdown
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 7, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

@ruanwenjun ruanwenjun merged commit 9c5808c into apache:dev May 7, 2026
168 of 174 checks passed
@ruanwenjun ruanwenjun deleted the refactor-api-replace-deprecated-checkProjectAndAuth branch May 7, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants