[Improvement-17564][Helm] Update MinIO Helm chart version#17955
Open
GaneshPatil7517 wants to merge 3 commits intoapache:devfrom
Open
[Improvement-17564][Helm] Update MinIO Helm chart version#17955GaneshPatil7517 wants to merge 3 commits intoapache:devfrom
GaneshPatil7517 wants to merge 3 commits intoapache:devfrom
Conversation
GaneshPatil7517
requested review from
Gallardot,
SbloodyS,
caishunfeng and
ruanwenjun
as code owners
GaneshPatil7517
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request claims to update the MinIO Helm chart version from 11.10.13 to 11.10.26 as part of a larger effort to update Bitnami Helm chart dependencies. However, the PR contains extensive unrelated Java code changes that refactor the workflow execution graph assembly to use a deferred initialization pattern.
Changes:
- MinIO Helm chart version updated from 11.10.13 to 11.10.26 in Chart.yaml
- Complete refactoring of workflow execution graph initialization to use deferred assembly pattern with IWorkflowExecutionGraphAssembler
- Multiple command handlers modified to create assembler lambdas instead of eagerly building execution graphs
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| deploy/kubernetes/dolphinscheduler/Chart.yaml | Updates MinIO dependency version from 11.10.13 to 11.10.26 |
| dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteContext.java | Adds deferred initialization support for workflow execution graph with volatile field and double-checked locking |
| dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/IWorkflowExecuteContext.java | Adds interface methods for initializing and checking workflow execution graph state |
| dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/workflow/statemachine/WorkflowRunningStateAction.java | Adds initialization logic with error handling during workflow start event |
| dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/graph/IWorkflowExecutionGraphAssembler.java | New functional interface for deferred workflow execution graph assembly |
| dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/command/handler/WorkflowFailoverCommandHandler.java | Refactors to create assembler lambda instead of eagerly building execution graph |
| dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/command/handler/RunWorkflowCommandHandler.java | Refactors to create assembler lambda instead of eagerly building execution graph |
| dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/command/handler/RecoverSerialWaitCommandHandler.java | Returns null assembler for serial wait recovery case |
| dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/command/handler/RecoverFailureTaskCommandHandler.java | Refactors to create assembler lambda instead of eagerly building execution graph |
| dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/command/handler/ReRunWorkflowCommandHandler.java | Wraps parent assembler to mark task instances as invalid before graph assembly |
| dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/command/handler/AbstractCommandHandler.java | Changes method signature from assembleWorkflowExecutionGraph to createWorkflowExecutionGraphAssembler |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.../dolphinscheduler/server/master/engine/command/handler/RecoverFailureTaskCommandHandler.java
Outdated
Show resolved
Hide resolved
.../apache/dolphinscheduler/server/master/engine/command/handler/RunWorkflowCommandHandler.java
Outdated
Show resolved
Hide resolved
...he/dolphinscheduler/server/master/engine/command/handler/WorkflowFailoverCommandHandler.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteContext.java
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...r/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteContext.java
Fixed
Show fixed
Hide fixed
Author
|
@Gallardot Could you please add the improvement label and set a milestone for this PR? |
SbloodyS
requested changes
Feb 6, 2026
Comment on lines
+129
to
+153
| /** | ||
| * Assemble the workflow execution graph assembler. | ||
| * <p> | ||
| * The assembler is used to defer the initialization of the WorkflowExecutionGraph | ||
| * until the WorkflowStartLifecycleEvent is fired. This reduces transaction time | ||
| * during command processing. | ||
| */ | ||
| protected void assembleWorkflowExecutionGraphAssembler( | ||
| final WorkflowExecuteContextBuilder workflowExecuteContextBuilder) { | ||
| final IWorkflowExecutionGraphAssembler assembler = createWorkflowExecutionGraphAssembler( | ||
| workflowExecuteContextBuilder); | ||
| workflowExecuteContextBuilder.setWorkflowExecutionGraphAssembler(assembler); | ||
| } | ||
|
|
||
| /** | ||
| * Create the workflow execution graph assembler. | ||
| * <p> | ||
| * Subclasses should implement this method to provide the logic for building | ||
| * the WorkflowExecutionGraph. The returned assembler will be invoked when | ||
| * the WorkflowStartLifecycleEvent is fired. | ||
| * | ||
| * @return the assembler for creating the WorkflowExecutionGraph, or null if no graph is needed | ||
| */ | ||
| protected abstract IWorkflowExecutionGraphAssembler createWorkflowExecutionGraphAssembler( | ||
| final WorkflowExecuteContextBuilder workflowExecuteContextBuilder); |
Member
There was a problem hiding this comment.
Please avoid all this unnessnary changes.
GaneshPatil7517
force-pushed
the
helm-update-minio-chart-version
branch
from
3eddb30 to
2ca7b65
Compare
ruanwenjun
reviewed
Feb 10, 2026
| condition: mysql.enabled | ||
| - name: minio | ||
| version: 11.10.13 | ||
| version: 11.10.26 |
Member
There was a problem hiding this comment.
We need to change the repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the MinIO Helm chart version to align with newer Bitnami Helm
charts and ensure compatibility with recent Helm updates.
Part of #17560.
Resolves #17564.