fix(grafana): use account email in Work Logs "Code commits" panel to fix 0-commit count for users with multiple accounts#8925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8833
Problem
The "Code commits" panel in the Work Logs dashboard shows 0 commits when
a user's DevLake profile email differs from their GitHub account email.
Cause
The
_accountsCTE was selectingu.email(DevLake user email) but thejoin used
c.author_id = a.emailwhich expects the GitHub account email.Fix
Changed
u.emailtoa.emailin the_accountsCTE so it correctlyuses the account email when matching commits.
Files Changed
grafana/dashboards/mysql/work-logs.jsongrafana/dashboards/postgresql/work-logs.json