Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Dec 9, 2023

Draft until #8463 is merged

Which issue does this PR close?

Follow on to #8463

Rationale for this change

#8463 removed the last use of SUPPORTED_STRUCT_TYPES so it is no longer needed in the code

What changes are included in this PR?

remove unused code

Are these changes tested?

Covered by existing tests

Are there any user-facing changes?

No

@github-actions github-actions bot added logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt) labels Dec 9, 2023
@alamb alamb force-pushed the alamb/delete_unused-code branch from a7b0615 to 676b59e Compare December 11, 2023 12:17
@alamb alamb marked this pull request as ready for review December 11, 2023 12:18
@korowa
Copy link
Contributor

korowa commented Dec 14, 2023

LGTM in DataFusion context, thank you @alamb

Just a question -- it doesn't look like a big deal for this one, but is it fine to remove public constant provided by crate without deprecating it first?

@alamb
Copy link
Contributor Author

alamb commented Dec 14, 2023

LGTM in DataFusion context, thank you @alamb

Just a question -- it doesn't look like a big deal for this one, but is it fine to remove public constant provided by crate without deprecating it first?

That is a good question @korowa -- I think it is a judgement call based on if we think removing the pub thing is likely to be encountered during upgrade and if the API change will be hard to adjust to for users.

In this case I don't think it will have a big impact, though I fully admit I have no data one way or the other

Copy link
Contributor

@metesynnada metesynnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this, since it is quite minor and will not introduce a big change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants