Add SQLOptions for controlling allowed SQL statements, update docs
#7333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Aug 18, 2023
| /// let results = df.collect(); | ||
| /// let results = df | ||
| /// .collect() | ||
| /// .await?; |
There was a problem hiding this comment.
since the results aren't checked it turns out this code was not actually running the plan (missing an await so I fixed that)
| @@ -2637,42 +2827,6 @@ mod tests { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
There was a problem hiding this comment.
I moved this into core_integration as it seemed like a test of the public API rather than an internal unit test
UlfarErl
reviewed
Aug 18, 2023
| LogicalPlan::Dml(dml) if !self.options.allow_dml => { | ||
| plan_err!("DML not supported: {}", dml.op) | ||
| } | ||
| LogicalPlan::Copy(_) if !self.options.allow_dml => { |
There was a problem hiding this comment.
Thanks so much @alamb for adding this to the core DF APIs. The addition of the Copy operator is a great example of why it belongs here: we already have a visitor that does similar filtering, but we would probably have failed to update it to include Copy when we migrate to the latest DF version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7328
Closes #7272
Rationale for this change
See #7328
Basically it is hard to understand how to control what SQL statements DataFusion will allow
What changes are included in this PR?
SQLOptionsandSessionContext::sql_with_optionsapisAre these changes tested?
Are there any user-facing changes?
New
SQLOptionsandSessionContext::sql_with_optionsapisEverything should be backwards compatible