Add Sqllogictests for INSERT INTO external table #7294
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7228
(^ this issue was closed prematurely with #7276 by accident, but this one should close it for real)
Rationale for this change
Existing Sqllogic tests for insert into only cover memory tables. Expanding this to cover external tables will improve our test coverage and validation of changes to FileSinks.
What changes are included in this PR?
insert_to_external.slt
which replicates many of the tests ininsert.slt
but for external ListingTablesCopy To
physical plan to a new methodListingTableUrl::parse_create_local_if_not_exists
Examples:
Create a single csv file and append values
Create a table backed by a directory of parquet files, insert new files
Are these changes tested?
Yes
Are there any user-facing changes?
More options supported!